Issue 11367095: Add an option to specify the versio to tweak_info_plist, and use it to set the version of content_s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11367095: Add an option to specify the versio to tweak_info_plist, and use it to set the version of content_s… (Closed)

Created:
8 years, 1 month ago by jochen (gone - plz use gerrit)

Modified:
8 years, 1 month ago

Reviewers:
Mark Mentovai, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Mike West

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add an option to specify the versio to tweak_info_plist, and use it to set the version of content_shell This breaks the dependency on chrome/VERSION to build content shell on mac BUG=156242 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166044

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -21 lines)			Patch
M	build/mac/tweak_info_plist.py	View		3 chunks	+27 lines, -15 lines	0 comments	Download
M	content/content_shell.gypi	View	1	3 chunks	+9 lines, -2 lines	0 comments	Download
M	content/shell/shell_content_client.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

jochen (gone - plz use gerrit)

plz review Mark, build/ John, content/

8 years, 1 month ago (2012-11-05 16:08:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11367095/4001

8 years, 1 month ago (2012-11-05 19:50:37 UTC) #4

Change committed as 166044