Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Issue 11367054: cc: Move textureUploadFlushPeriod to TextureUploader. (Closed)

Created:
8 years, 1 month ago by reveman
Modified:
8 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, nduca, brianderson, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Move textureUploadFlushPeriod to TextureUploader. This moves texture upload related flushing to the TextureUploader class. This is a more appropriate place to handle this type of flushing and makes it possible to avoid some unnecessary flushes. BUG= TEST=cc_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -32 lines) Patch
M cc/resource_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resource_provider.cc View 2 chunks +9 lines, -1 line 0 comments Download
M cc/resource_update_controller.cc View 3 chunks +6 lines, -25 lines 0 comments Download
M cc/texture_uploader.h View 4 chunks +13 lines, -3 lines 0 comments Download
M cc/texture_uploader.cc View 3 chunks +22 lines, -1 line 0 comments Download
M cc/texture_uploader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reveman
8 years, 1 month ago (2012-11-02 03:17:23 UTC) #1
enne (OOO)
lgtm It definitely seems like that's the right place for flushing anyway. The controller shouldn't ...
8 years, 1 month ago (2012-11-02 16:50:34 UTC) #2
reveman
On 2012/11/02 16:50:34, enne wrote: > lgtm > > It definitely seems like that's the ...
8 years, 1 month ago (2012-11-02 17:24:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/11367054/1
8 years, 1 month ago (2012-11-02 18:01:18 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-02 18:07:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/11367054/1
8 years, 1 month ago (2012-11-03 18:49:03 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-03 20:52:36 UTC) #7
Change committed as 165860

Powered by Google App Engine
This is Rietveld 408576698