chrome/browser/chromeos/status/network_menu.cc - Issue 11367048: This is the first pass at making GetIPConfigs asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/status/network_menu.cc

Issue 11367048: This is the first pass at making GetIPConfigs asynchronous. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/status/network_menu.cc

diff --git a/chrome/browser/chromeos/status/network_menu.cc b/chrome/browser/chromeos/status/network_menu.cc

index 6ef7c9a6f4d194fa893927c11d024e5e6cbf9e06..f4680248e7edb78dd01574197ed984400bd9219b 100644

--- a/chrome/browser/chromeos/status/network_menu.cc

+++ b/chrome/browser/chromeos/status/network_menu.cc

@@ -864,7 +864,7 @@ void MoreMenuModel::InitMenuItems(bool should_open_button_options) {

const NetworkDevice* ether = cros->FindEthernetDevice();

if (ether) {

std::string hardware_address;

- cros->GetIPConfigs(ether->device_path(), &hardware_address,

+ cros->GetIPConfigsAndBlock(ether->device_path(), &hardware_address,

NetworkLibrary::FORMAT_COLON_SEPARATED_HEX);

if (!hardware_address.empty()) {

std::string label = l10n_util::GetStringUTF8(

@@ -878,7 +878,7 @@ void MoreMenuModel::InitMenuItems(bool should_open_button_options) {

const NetworkDevice* wifi = cros->FindWifiDevice();

if (wifi) {

std::string hardware_address;

- cros->GetIPConfigs(wifi->device_path(),

+ cros->GetIPConfigsAndBlock(wifi->device_path(),

&hardware_address, NetworkLibrary::FORMAT_COLON_SEPARATED_HEX);

if (!hardware_address.empty()) {

std::string label = l10n_util::GetStringUTF8(