Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 11367014: Make OAuthUserInfoUrl configurable. (Closed)

Created:
8 years, 1 month ago by rmsousa
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make OAuthUserInfoUrl configurable. BUG=97126 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M google_apis/gaia/gaia_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_switches.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/gaia_urls.cc View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
rmsousa
I need to make this particular URL configurable for test purposes. (I didn't need the ...
8 years, 1 month ago (2012-10-31 21:30:30 UTC) #1
Joao da Silva
lgtm (sorry about the long delay! I've been OOO)
8 years, 1 month ago (2012-11-06 08:05:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmsousa@chromium.org/11367014/1
8 years, 1 month ago (2012-11-07 03:35:57 UTC) #3
commit-bot: I haz the power
Presubmit check for 11367014-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-07 03:36:00 UTC) #4
rmsousa
8 years, 1 month ago (2012-11-07 03:48:34 UTC) #5
Roger Tawa OOO till Jul 10th
Lgtm On Nov 6, 2012 10:48 PM, <rmsousa@chromium.org> wrote: > https://chromiumcodereview.**appspot.com/11367014/<https://chromiumcodereview.appspot.com/11367014/> >
8 years, 1 month ago (2012-11-07 13:27:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmsousa@chromium.org/11367014/1
8 years, 1 month ago (2012-11-12 19:34:45 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-13 03:57:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmsousa@chromium.org/11367014/1
8 years, 1 month ago (2012-11-13 19:32:04 UTC) #9
commit-bot: I haz the power
8 years, 1 month ago (2012-11-13 20:12:05 UTC) #10
Change committed as 167445

Powered by Google App Engine
This is Rietveld 408576698