Issue 11366241: Removed IMMNotification from WASAPIAudioOutputStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11366241: Removed IMMNotification from WASAPIAudioOutputStream. (Closed)

Created:
8 years, 1 month ago by henrika (OOO until Aug 14)

Modified:
8 years, 1 month ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, feature-media-reviews_chromium.org, DaleCurtis

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removed IMMNotification from WASAPIAudioOutputStream. The implementation of IMMNotification has been disabled since we started to use a separate IMMNotification implementation in AudioDeviceListenerWin. It means that some code has been "dead" and it was my task to remove the non-used code. BUG=none TEST=manual tests in Chrome to verify that device switch still works using the existing framework. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167674

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -228 lines)			Patch
	M	media/audio/win/audio_low_latency_output_win.h	View		9 chunks	+2 lines, -75 lines	0 comments	Download
	M	media/audio/win/audio_low_latency_output_win.cc	View		5 chunks	+0 lines, -153 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/11366241/1

8 years, 1 month ago (2012-11-14 12:27:04 UTC) #3

Change committed as 167674

Expand Messages | Collapse Messages