Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 11366226: Rename capture and encode threads to make it clear that they are for video. (Closed)

Created:
8 years, 1 month ago by Sergey Ulanov
Modified:
8 years, 1 month ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Rename capture and encode threads to make it clear that they are for video. Renamed capture thread to video_capture thread and encode thread to video_encode thread. It's mainly to prevent bugs like crbug.com/157992 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -52 lines) Patch
M remoting/host/chromoting_host.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/chromoting_host.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/chromoting_host_context.h View 3 chunks +7 lines, -7 lines 0 comments Download
M remoting/host/chromoting_host_context.cc View 5 chunks +15 lines, -13 lines 0 comments Download
M remoting/host/chromoting_host_context_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/client_session.h View 2 chunks +12 lines, -10 lines 0 comments Download
M remoting/host/client_session.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/plugin/host_script_object.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
8 years, 1 month ago (2012-11-13 18:52:39 UTC) #1
Wez
lgtm
8 years, 1 month ago (2012-11-14 00:45:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11366226/1
8 years, 1 month ago (2012-11-14 01:01:32 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-14 04:11:21 UTC) #4
Change committed as 167591

Powered by Google App Engine
This is Rietveld 408576698