Issue 11366163: Build and archive the new chromedriver library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11366163: Build and archive the new chromedriver library. (Closed)

Created:
8 years, 1 month ago by kkania

Modified:
8 years, 1 month ago

Reviewers:
dennis_jeffrey, sky

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Build and archive the new chromedriver (and unittests) on the bots. Also, switch chromedriver2 to a loadable_module, since we never intend to link against it, just dlopen it. NOTRY=true BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166919

Patch Set 1 #

Patch Set 2 : . #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
M	build/all.gyp	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/build/linux/TESTS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/tools/build/mac/TESTS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/tools/build/win/TESTS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kkania

dennisjeffrey: review sky: OWNERS review for all files needed except build/all.gyp

8 years, 1 month ago (2012-11-08 22:06:38 UTC) #1

dennis_jeffrey

LGTM I'm not familiar with the names of the different chromedriver2 binaries on the different ...

8 years, 1 month ago (2012-11-08 22:16:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/11366163/4001

8 years, 1 month ago (2012-11-09 17:04:58 UTC) #4

Change committed as 166919

Expand Messages | Collapse Messages