[Media Gallery][ChromeOS] Improve device media gallery names.

chrome/browser/system_monitor/removable_device_notifications_chromeos.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // chromeos::RemovableDeviceNotificationsCros listens for mount point changes
 // and notifies the SystemMonitor about the addition and deletion of media
 // devices.
 
 #ifndef CHROME_BROWSER_SYSTEM_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_CHROMEOS_H_
 #define CHROME_BROWSER_SYSTEM_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_CHROMEOS_H_
@@ skipping 42 matching lines @@
       disks::DiskMountManager::MountEvent event_type,
       MountError error_code,
       const disks::DiskMountManager::MountPointInfo& mount_info) OVERRIDE;
 
   // Finds the device that contains |path| and populates |device_info|.
   // Returns false if unable to find the device.
   bool GetDeviceInfoForPath(
       const FilePath& path,
       base::SystemMonitor::RemovableStorageInfo* device_info) const;
 
+  // Returns the storage size information of the device present at |location|.
+  // If the requested information is unavailable, returns an empty string.
+  string16 GetStorageSizeInfo(const std::string& location);
+
  private:
+  struct StorageObjectInfo {
+    // Basic details {storage device name, location and identifier}.
+    base::SystemMonitor::RemovableStorageInfo storage_info;
+
+    // Device storage size, e.g "4 GB", "15.9 MB".
+    string16 storage_size_info;

[Lei Zhang, 2012/11/09 01:12:18]

How about storage_size_str ?

[Lei Zhang, 2012/11/09 04:47:05]

BTW, have you considered just storing this as a uint64, instead of a string?
That way, only the common places that need to format it for human readability
can call FormatBytes(), rather than every GetStorageInfo() function.

[kmadhusu, 2012/11/09 21:59:40]

storage_size_info -> storage_size.

[kmadhusu, 2012/11/09 21:59:40]

I don't see any reason to store this as uint64. Every caller who access this
function will eventually call FormatBytes.

[Lei Zhang, 2012/11/12 07:46:56]

So with this CL and the Linux equivalent, both
removable_device_notifications_chromeos.cc and
removable_device_notifications_linux.cc have to call FormatBytes() in their
respective GetDeviceInfo functions.

Alternatively, you can keep it as a uint64, then the function that calls
FormatBytes() will be GetDisplayNameForDevice(). Wouldn't calling FormatBytes()
in the function that format the names for display make more sense?

[kmadhusu, 2012/11/12 19:56:56]

Done.

+  };
+
   friend class base::RefCountedThreadSafe<RemovableDeviceNotificationsCros>;
 
   // Mapping of mount path to removable mass storage info.
-  typedef std::map<std::string, base::SystemMonitor::RemovableStorageInfo>
-      MountMap;
+  typedef std::map<std::string, StorageObjectInfo> MountMap;
 
   // Private to avoid code deleting the object.
   virtual ~RemovableDeviceNotificationsCros();
 
   // Checks existing mount points map for media devices. For each mount point,
   // call CheckMountedPathOnFileThread() below.
   void CheckExistingMountPointsOnUIThread();
 
   // Checks if the mount point in |mount_info| is a media device. If it is,
   // then continue with AddMountedPathOnUIThread() below.
@@ skipping 10 matching lines @@
   // Mapping of relevant mount points and their corresponding mount devices.
   // Only accessed on the UI thread.
   MountMap mount_map_;
 
   DISALLOW_COPY_AND_ASSIGN(RemovableDeviceNotificationsCros);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_SYSTEM_MONITOR_REMOVABLE_DEVICE_NOTIFICATIONS_CHROMEOS_H_