Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: content/browser/download/download_item_impl.h

Issue 11366121: Split DownloadFile::Rename into RenameAndUniquify and RenameAndAnnotate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl.h
diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h
index e0866550616cb404b2cc5e9f7f11cf7657629278..366b90ccc99cf5dfaec515c74834222f27e151ba 100644
--- a/content/browser/download/download_item_impl.h
+++ b/content/browser/download/download_item_impl.h
@@ -277,12 +277,6 @@ class CONTENT_EXPORT DownloadItemImpl
void OnDownloadRenamedToFinalName(DownloadInterruptReason reason,
const FilePath& full_path);
- void ReleaseDownloadFile();
-
- // TODO(rdsmith,asanka): Move the AnnotateWithSourceInformation() call to the
- // final rename and eliminate the interrupt reason callback.
- void OnDownloadFileReleased(DownloadInterruptReason reason);
-
// Called when the entire download operation (including renaming etc)
// is completed.
void Completed();
@@ -295,10 +289,6 @@ class CONTENT_EXPORT DownloadItemImpl
// Check if a download is ready for completion.
bool IsDownloadReadyForCompletion();
- // Returns true if the download still needs to be renamed to
- // GetTargetFilePath().
- bool NeedsRename() const;
-
// Call to transition state; all state transitions should go through this.
void TransitionTo(DownloadInternalState new_state);

Powered by Google App Engine
This is Rietveld 408576698