Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 11366107: Merge 133052 - Web Inspector: frame chooser does not work on subsequent inspector open. (Closed)

Created:
8 years, 1 month ago by pfeldman
Modified:
8 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 133052 - Web Inspector: frame chooser does not work on subsequent inspector open. https://bugs.webkit.org/show_bug.cgi?id=100771 Reviewed by Yury Semikhatsky. - Make WorkerRuntimeAgent and PageRuntimeAgent register themselves in the instrumenting agents independently - Move pause / run worker handling from InspectorRuntimeAgent into WorkerRuntimeAgent - Remove remains of the front-end reused signal from InspectorAgent - Send execution contexts post clear window object instead of post commit load. * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::clearFrontend): (WebCore::InspectorAgent::didCommitLoad): * inspector/InspectorAgent.h: (InspectorAgent): * inspector/InspectorInstrumentation.cpp: (WebCore): (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::willEvaluateWorkerScript): * inspector/InspectorInstrumentation.h: (InspectorInstrumentation): * inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::restore): * inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::run): (WebCore::InspectorRuntimeAgent::setScriptDebugServer): * inspector/InspectorRuntimeAgent.h: (InspectorRuntimeAgent): * inspector/InstrumentingAgents.h: (WebCore): (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::workerRuntimeAgent): (WebCore::InstrumentingAgents::setWorkerRuntimeAgent): (InstrumentingAgents): * inspector/PageRuntimeAgent.cpp: (WebCore::PageRuntimeAgent::PageRuntimeAgent): (WebCore::PageRuntimeAgent::~PageRuntimeAgent): (WebCore::PageRuntimeAgent::setFrontend): (WebCore::PageRuntimeAgent::clearFrontend): (WebCore::PageRuntimeAgent::enable): (WebCore::PageRuntimeAgent::didCreateMainWorldContext): * inspector/PageRuntimeAgent.h: (PageRuntimeAgent): * inspector/WorkerRuntimeAgent.cpp: (WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent): (WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent): (WebCore::WorkerRuntimeAgent::run): (WebCore): (WebCore::WorkerRuntimeAgent::pauseWorkerContext): * inspector/WorkerRuntimeAgent.h: (WorkerRuntimeAgent): TBR=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -64 lines) Patch
M Source/WebCore/inspector/InspectorAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorAgent.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/InspectorController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorInstrumentation.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorInstrumentation.cpp View 5 chunks +3 lines, -10 lines 0 comments Download
M Source/WebCore/inspector/InspectorPageAgent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/InspectorRuntimeAgent.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorRuntimeAgent.cpp View 4 chunks +0 lines, -21 lines 0 comments Download
M Source/WebCore/inspector/InstrumentingAgents.h View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/WebCore/inspector/PageRuntimeAgent.h View 3 chunks +5 lines, -6 lines 0 comments Download
M Source/WebCore/inspector/PageRuntimeAgent.cpp View 4 chunks +8 lines, -7 lines 0 comments Download
M Source/WebCore/inspector/WorkerRuntimeAgent.h View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/WorkerRuntimeAgent.cpp View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
8 years, 1 month ago (2012-11-06 15:12:54 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698