|
cc: Create a Region class that wraps SkRegion, to replace use of WebCore::Region.
We create a class in cc/ called Region which provides a gfx:: type-friendly API
to SkRegion, and allows for easily swapping out region implementations in the
future if required.
During the process, I removed tests dependency on a "size()" method on Region,
that used to give the number of rects in the Region's internal representation.
Instead, we always create a Region in the tests from our expected rects, and
compare the Regions directly. We use ToString() comparisons to get useful
failure outputs, similar to the unit tests of other geometry types in ui/gfx.
This uncovered a WTF::Vector holdout in the OcclusionTracker class, which is
converted to a std::vector.
Covered by existing tests; no change in behaviour.
R=enne
BUG= 147395
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166617
Total comments: 3
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+954 lines, -515 lines) |
Patch |
 |
M |
cc/DEPS
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/cc.gyp
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cc/cc_tests.gyp
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cc/layer.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
cc/layer_impl.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
cc/layer_sorter.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
cc/layer_tiling_data.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
cc/layer_tree_host.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/layer_tree_host_impl.cc
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/layer_tree_host_impl_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
4 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/layer_tree_host_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
11 chunks |
+39 lines, -79 lines |
0 comments
|
Download
|
 |
M |
cc/math_util.h
|
View
|
1
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/math_util.cc
|
View
|
1
2
|
2 chunks |
+4 lines, -7 lines |
0 comments
|
Download
|
 |
M |
cc/occlusion_tracker.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/occlusion_tracker.cc
|
View
|
|
10 chunks |
+31 lines, -31 lines |
0 comments
|
Download
|
 |
M |
cc/occlusion_tracker_unittest.cc
|
View
|
|
50 chunks |
+158 lines, -250 lines |
0 comments
|
Download
|
 |
M |
cc/quad_culler.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
A |
cc/region.h
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+125 lines, -0 lines |
0 comments
|
Download
|
 |
A |
cc/region.cc
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+109 lines, -0 lines |
0 comments
|
Download
|
 |
A |
cc/region_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+420 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/render_surface_impl.cc
|
View
|
1
2
3
4
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
D |
cc/stubs/Region.h
|
View
|
|
1 chunk |
+0 lines, -98 lines |
0 comments
|
Download
|
 |
M |
cc/test/layer_test_common.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
cc/test/occlusion_tracker_test_common.h
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
cc/test/tiled_layer_test_common.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
cc/tiled_layer.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/tiled_layer_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
5 chunks |
+6 lines, -10 lines |
0 comments
|
Download
|
 |
M |
cc/tree_synchronizer_unittest.cc
|
View
|
1
2
3
4
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
webkit/compositor_bindings/web_layer_impl.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
3 chunks |
+26 lines, -14 lines |
0 comments
|
Download
|
Total messages: 17 (0 generated)
|