Add a native test target and for android_webview.

Add a native test target and for android_webview.

This adds the .gyp target for the android_webview native unittests.
This change also adds running them to the fyi bot.

BUG=None
Android-only chagne, ran through trybots before submitting.
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165920

[mkosiba (inactive), 2012-11-02 10:22:06]

@torne for android_webview
@bulach for the rest
@cmp for infrastructure ACK as I'm adding a new step to the bots

[Torne, 2012-11-02 10:51:40]

Restructuring of android_webview LGTM.

[joth, 2012-11-02 11:06:07]

http://codereview.chromium.org/11366035/diff/2002/android_webview/android_web...
File android_webview/android_webview_tests.gypi (right):

http://codereview.chromium.org/11366035/diff/2002/android_webview/android_web...
android_webview/android_webview_tests.gypi:15:
'../chrome/chrome_resources.gyp:packed_resources',
hmmm. seems odd we have to duplicate all the SUT's dependencies. Is this normal?

http://codereview.chromium.org/11366035/diff/2002/android_webview/native/andr...
File android_webview/native/android_stream_reader_url_request_job_unittests.cc
(right):

http://codereview.chromium.org/11366035/diff/2002/android_webview/native/andr...
android_webview/native/android_stream_reader_url_request_job_unittests.cc:7:
#include "testing/gmock/include/gmock/gmock.h"
nit: gmock no needed

http://codereview.chromium.org/11366035/diff/2002/build/android/buildbot/buil...
File build/android/buildbot/buildbot_functions.sh (right):

http://codereview.chromium.org/11366035/diff/2002/build/android/buildbot/buil...
build/android/buildbot/buildbot_functions.sh:213: build/android/run_tests.py
--xvfb --verbose -s android_webview_unittests
I'll let cmp comment on this one, but I'd be slightly inclined to have this in
its own CL (cus then you can land the rest in GMT)
.

[mkosiba (inactive), 2012-11-02 15:59:39]

http://codereview.chromium.org/11366035/diff/2002/android_webview/android_web...
File android_webview/android_webview_tests.gypi (right):

http://codereview.chromium.org/11366035/diff/2002/android_webview/android_web...
android_webview/android_webview_tests.gypi:15:
'../chrome/chrome_resources.gyp:packed_resources',
On 2012/11/02 11:06:07, joth wrote:
> hmmm. seems odd we have to duplicate all the SUT's dependencies. Is this
normal?

hmm.. it was always like that, but seems to work with a reduced deps set too.

http://codereview.chromium.org/11366035/diff/2002/android_webview/native/andr...
File android_webview/native/android_stream_reader_url_request_job_unittests.cc
(right):

http://codereview.chromium.org/11366035/diff/2002/android_webview/native/andr...
android_webview/native/android_stream_reader_url_request_job_unittests.cc:7:
#include "testing/gmock/include/gmock/gmock.h"
On 2012/11/02 11:06:07, joth wrote:
> nit: gmock no needed

Done.

http://codereview.chromium.org/11366035/diff/2002/build/android/buildbot/buil...
File build/android/buildbot/buildbot_functions.sh (right):

http://codereview.chromium.org/11366035/diff/2002/build/android/buildbot/buil...
build/android/buildbot/buildbot_functions.sh:213: build/android/run_tests.py
--xvfb --verbose -s android_webview_unittests
On 2012/11/02 11:06:07, joth wrote:
> I'll let cmp comment on this one, but I'd be slightly inclined to have this in
> its own CL (cus then you can land the rest in GMT)
> .

Done.

[bulach, 2012-11-02 16:41:33]

sorry about the delay... lgtm, just some small suggestions:

http://codereview.chromium.org/11366035/diff/10002/android_webview/android_we...
File android_webview/android_webview_tests.gypi (right):

http://codereview.chromium.org/11366035/diff/10002/android_webview/android_we...
android_webview/android_webview_tests.gypi:24: 'files': [ '<!@(find
<(java_in_dir)/assets -type f -name "*")' ]
nit: -name "*" is spurious here..

http://codereview.chromium.org/11366035/diff/10002/android_webview/native/and...
File android_webview/native/android_stream_reader_url_request_job_unittests.cc
(right):

http://codereview.chromium.org/11366035/diff/10002/android_webview/native/and...
android_webview/native/android_stream_reader_url_request_job_unittests.cc:10: //
changes.
I got a suggestion once for always linking a crbug.com/xyz for TODOs, so that it
contains more context on what's going on.

[mkosiba (inactive), 2012-11-05 10:25:10]

http://codereview.chromium.org/11366035/diff/10002/android_webview/android_we...
File android_webview/android_webview_tests.gypi (right):

http://codereview.chromium.org/11366035/diff/10002/android_webview/android_we...
android_webview/android_webview_tests.gypi:24: 'files': [ '<!@(find
<(java_in_dir)/assets -type f -name "*")' ]
On 2012/11/02 16:41:34, bulach wrote:
> nit: -name "*" is spurious here..

Done.

http://codereview.chromium.org/11366035/diff/10002/android_webview/native/and...
File android_webview/native/android_stream_reader_url_request_job_unittests.cc
(right):

http://codereview.chromium.org/11366035/diff/10002/android_webview/native/and...
android_webview/native/android_stream_reader_url_request_job_unittests.cc:10: //
changes.
On 2012/11/02 16:41:34, bulach wrote:
> I got a suggestion once for always linking a crbug.com/xyz for TODOs, so that
it
> contains more context on what's going on.

there is no bug as such - I'm adding tests in a change I'm working on now so
it's unlikely that this will be lost.

[commit-bot: I haz the power, 2012-11-05 11:27:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/11366035/12003

[commit-bot: I haz the power, 2012-11-05 11:49:41]

Change committed as 165920