Issue 113653003: Add base:: to straggling string16 in content/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113653003: Add base:: to straggling string16 in content/. (Closed)

Created:
7 years ago by Dan Beam

Modified:
7 years ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	content/shell/renderer/test_runner/MockGrammarCheck.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/shell/renderer/test_runner/MockSpellCheck.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/renderer/test_runner/MockSpellCheck.cpp	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	content/shell/renderer/test_runner/SpellCheckClient.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/renderer/test_runner/WebTestProxy.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Dan Beam

this code https://chromiumcodereview.appspot.com/105143014/ was moved to content/ while my other change was in flight.

7 years ago (2013-12-20 19:01:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/113653003/1

7 years ago (2013-12-20 23:09:51 UTC) #3

Message was sent while issue was closed.

Change committed as 242231