Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 11365247: cc: Clamp the fixed thumb size to be at least zero. (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Clamp the fixed thumb size to be at least zero. WebKit is providing a negative thumb size sometimes, which causes asserts in gfx::Size once we re-enable those DCHECKs. BUG=160799 R=enne Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167766

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M cc/scrollbar_geometry_stub.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
Hey Enne. I was not certain if this is the best spot for clamping, but ...
8 years, 1 month ago (2012-11-14 02:35:11 UTC) #1
enne (OOO)
Yeaaah, geometry and scrollbar stuff is not the best. This is still probably better done ...
8 years, 1 month ago (2012-11-14 17:19:10 UTC) #2
danakj
Ok! Done.
8 years, 1 month ago (2012-11-14 19:17:49 UTC) #3
enne (OOO)
lgtm
8 years, 1 month ago (2012-11-14 19:20:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11365247/1002
8 years, 1 month ago (2012-11-14 19:23:37 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-14 23:35:07 UTC) #6
Change committed as 167766

Powered by Google App Engine
This is Rietveld 408576698