Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11365227: Reland 167337 - Move url_request_test_util into net namespace (Closed)

Created:
8 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
8 years, 1 month ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, shishir+watch_chromium.org, tzik+watch_chromium.org, amit, kinuko+watch, rouslan+watch_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, gbillock+watch_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), groby+watch_chromium.org, Raghu Simha, pam+watch_chromium.org, oshima+watch_chromium.org, haitaol1, michaeln, akalin, stevenjb+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, robertshield, smckay+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Reland 167337 - Move url_request_test_util into net namespace This file contains some rather generic names like "TestDelegate". Move it to the net namespace to avoid collisions BUG=none TBR=wtc@chromium.org,darin@chromium.org Original Review URL: https://codereview.chromium.org/11369179 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167413

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -346 lines) Patch
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 6 chunks +22 lines, -21 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 7 chunks +26 lines, -25 lines 0 comments Download
M chrome/browser/intents/cws_intents_registry_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/net/http_pipelining_compatibility_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_interative_uitest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/test_server_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/mock_resource_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/proxy_resolving_client_socket_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M jingle/notifier/base/xmpp_connection_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M jingle/notifier/listener/push_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M jingle/notifier/listener/xmpp_push_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/socket_stream/socket_stream_unittest.cc View 23 chunks +55 lines, -55 lines 0 comments Download
M net/url_request/url_request_job_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/url_request/url_request_test_util.h View 12 chunks +66 lines, -63 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 22 chunks +81 lines, -78 lines 0 comments Download
M rlz/lib/rlz_lib_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M sync/notifier/invalidator_factory_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/notifier/non_blocking_invalidator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/tools/sync_listen_notifications.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_update_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11365227/1040
8 years, 1 month ago (2012-11-13 15:25:28 UTC) #1
wtc
Patch set 1 LGTM. Why was the original CL reverted? Did you make any change ...
8 years, 1 month ago (2012-11-13 16:07:41 UTC) #2
jochen (gone - plz use gerrit)
On 2012/11/13 16:07:41, wtc wrote: > Patch set 1 LGTM. > > Why was the ...
8 years, 1 month ago (2012-11-13 16:10:59 UTC) #3
wtc
No problem. The rlz/ change LGTM.
8 years, 1 month ago (2012-11-13 16:47:21 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-13 17:49:23 UTC) #5 
Change committed as 167413

Powered by Google App Engine
This is Rietveld 408576698