Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5763)

Unified Diff: chrome/browser/extensions/event_router.cc

Issue 11365181: Remove GetExtensionService from Profile. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: replace missing extension_system include Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/event_router.cc
diff --git a/chrome/browser/extensions/event_router.cc b/chrome/browser/extensions/event_router.cc
index 3fe9f1622a16e76c62c8d9335795ef4f45a590d4..76aa015c40802bd5d00ac3b35ab6f2b9bf84e4cc 100644
--- a/chrome/browser/extensions/event_router.cc
+++ b/chrome/browser/extensions/event_router.cc
@@ -236,8 +236,8 @@ void EventRouter::AddLazyEventListener(const std::string& event_name,
bool is_new = listeners_.AddListener(listener.Pass());
if (is_new) {
- ExtensionPrefs* prefs =
- profile_->GetExtensionService()->extension_prefs();
+ ExtensionPrefs* prefs = extensions::ExtensionSystem::Get(profile_)->
+ extension_service()->extension_prefs();
std::set<std::string> events = prefs->GetRegisteredEvents(extension_id);
bool prefs_is_new = events.insert(event_name).second;
if (prefs_is_new)
@@ -252,8 +252,8 @@ void EventRouter::RemoveLazyEventListener(const std::string& event_name,
bool did_exist = listeners_.RemoveListener(&listener);
if (did_exist) {
- ExtensionPrefs* prefs =
- profile_->GetExtensionService()->extension_prefs();
+ ExtensionPrefs* prefs = extensions::ExtensionSystem::Get(profile_)->
+ extension_service()->extension_prefs();
std::set<std::string> events = prefs->GetRegisteredEvents(extension_id);
bool prefs_did_exist = events.erase(event_name) > 0;
DCHECK(prefs_did_exist);
@@ -276,8 +276,8 @@ void EventRouter::AddFilteredEventListener(const std::string& event_name,
scoped_ptr<DictionaryValue>(filter.DeepCopy()))));
if (added) {
- ExtensionPrefs* prefs =
- profile_->GetExtensionService()->extension_prefs();
+ ExtensionPrefs* prefs = extensions::ExtensionSystem::Get(profile_)->
+ extension_service()->extension_prefs();
prefs->AddFilterToEvent(event_name, extension_id, &filter);
}
}
@@ -299,8 +299,8 @@ void EventRouter::RemoveFilteredEventListener(
bool removed = listeners_.RemoveListener(&listener);
if (removed) {
- ExtensionPrefs* prefs =
- profile_->GetExtensionService()->extension_prefs();
+ ExtensionPrefs* prefs = extensions::ExtensionSystem::Get(profile_)->
+ extension_service()->extension_prefs();
prefs->RemoveFilterFromEvent(event_name, extension_id, &filter);
}
}
@@ -454,7 +454,8 @@ void EventRouter::DispatchLazyEvent(
const std::string& extension_id,
const linked_ptr<Event>& event,
std::set<EventDispatchIdentifier>* already_dispatched) {
- ExtensionService* service = profile_->GetExtensionService();
+ ExtensionService* service =
+ extensions::ExtensionSystem::Get(profile_)->extension_service();
// Check both the original and the incognito profile to see if we
// should load a lazy bg page to handle the event. The latter case
// occurs in the case of split-mode extensions.
@@ -479,7 +480,8 @@ void EventRouter::DispatchLazyEvent(
void EventRouter::DispatchEventToProcess(const std::string& extension_id,
content::RenderProcessHost* process,
const linked_ptr<Event>& event) {
- ExtensionService* service = profile_->GetExtensionService();
+ ExtensionService* service =
+ extensions::ExtensionSystem::Get(profile_)->extension_service();
const Extension* extension = service->extensions()->GetByID(extension_id);
// The extension could have been removed, but we do not unregister it until
@@ -489,8 +491,8 @@ void EventRouter::DispatchEventToProcess(const std::string& extension_id,
Profile* listener_profile = Profile::FromBrowserContext(
process->GetBrowserContext());
- ProcessMap* process_map =
- listener_profile->GetExtensionService()->process_map();
+ ProcessMap* process_map = extensions::ExtensionSystem::Get(listener_profile)->
+ extension_service()->process_map();
// If the event is privileged, only send to extension processes. Otherwise,
// it's OK to send to normal renderers (e.g., for content scripts).
if (ExtensionAPI::GetSharedInstance()->IsPrivileged(event->event_name) &&
@@ -523,7 +525,8 @@ bool EventRouter::CanDispatchEventToProfile(Profile* profile,
bool cross_incognito =
event->restrict_to_profile && profile != event->restrict_to_profile;
if (cross_incognito &&
- !profile->GetExtensionService()->CanCrossIncognito(extension)) {
+ !extensions::ExtensionSystem::Get(profile)->extension_service()->
+ CanCrossIncognito(extension)) {
if (!event->cross_incognito_args.get())
return false;
// Send the event with different arguments to extensions that can't
@@ -626,8 +629,8 @@ void EventRouter::Observe(int type,
// Add all registered lazy listeners to our cache.
const Extension* extension =
content::Details<const Extension>(details).ptr();
- ExtensionPrefs* prefs =
- profile_->GetExtensionService()->extension_prefs();
+ ExtensionPrefs* prefs = extensions::ExtensionSystem::Get(profile_)->
+ extension_service()->extension_prefs();
std::set<std::string> registered_events =
prefs->GetRegisteredEvents(extension->id());
listeners_.LoadUnfilteredLazyListeners(extension->id(),
« no previous file with comments | « chrome/browser/extensions/crx_installer_browsertest.cc ('k') | chrome/browser/extensions/extension_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698