Remove GetExtensionService from Profile.

chrome/browser/extensions/settings/settings_test_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/settings/settings_test_util.h"
 
 #include "base/file_path.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/browser/extensions/extension_system_factory.h"
 #include "chrome/browser/extensions/settings/settings_frontend.h"
@@ skipping 100 matching lines @@
 MockExtensionSystem::MockExtensionSystem(Profile* profile)
       : TestExtensionSystem(profile) {}
 MockExtensionSystem::~MockExtensionSystem() {}
 
 EventRouter* MockExtensionSystem::event_router() {
   if (!event_router_.get())
     event_router_.reset(new EventRouter(profile_, NULL));
   return event_router_.get();
 }
 
+ExtensionService* MockExtensionSystem::extension_service() {
+  ExtensionServiceInterface* as_interface =
+      static_cast<ExtensionServiceInterface*>(&extension_service_);

[Yoyo Zhou, 2012/11/21 00:27:13]

ditto

[Miranda Callahan, 2012/11/26 22:14:24]

Unfortunately, all this casting is needed, as MockExtensionService ISA
TestExtensionService ISA ExtensionServiceInterface -- this is the common
ancestor of the Mock and the actual ExtensionService. Which is just icky, but
maybe refactoring this can be in a separate CL.

[Yoyo Zhou, 2012/11/26 22:58:04]

You don't need it for the upcasting on this line, I thought.

[Miranda Callahan, 2012/11/29 17:36:35]

This probably needs refactoring to get rid of the confusion it's cost both of
us. :-P  This is actually a downcast -- we cast the MockExtensionSVC up to the
ExtensionSVCInterface, and then back down to an ExtensionSVC. The real question
is "how does this even work?" 

+  return static_cast<ExtensionService*>(as_interface);
+}
+
 ProfileKeyedService* BuildMockExtensionSystem(Profile* profile) {
   return new MockExtensionSystem(profile);
 }
 
 // MockProfile
 
 MockProfile::MockProfile(const FilePath& file_path)
     : TestingProfile(file_path) {
   ExtensionSystemFactory::GetInstance()->SetTestingFactoryAndUse(this,
       &BuildMockExtensionSystem);
@@ skipping 29 matching lines @@
 ValueStore* ScopedSettingsStorageFactory::Create(
     const FilePath& base_path,
     const std::string& extension_id) {
   DCHECK(delegate_.get());
   return delegate_->Create(base_path, extension_id);
 }
 
 }  // namespace settings_test_util
 
 }  // namespace extensions