Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2370)

Unified Diff: chrome/browser/system_monitor/removable_device_notifications_chromeos.cc

Issue 11365142: Small refactoring in DiskMountManager (event reporting; format method). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: few lint nits Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/system_monitor/removable_device_notifications_chromeos.cc
diff --git a/chrome/browser/system_monitor/removable_device_notifications_chromeos.cc b/chrome/browser/system_monitor/removable_device_notifications_chromeos.cc
index c8b90e97872f17dad7717e83231faef5f8e2c8c0..df1753a17253fd31abc2a5b801de8a62a986e4ee 100644
--- a/chrome/browser/system_monitor/removable_device_notifications_chromeos.cc
+++ b/chrome/browser/system_monitor/removable_device_notifications_chromeos.cc
@@ -120,18 +120,18 @@ void RemovableDeviceNotificationsCros::CheckExistingMountPointsOnUIThread() {
}
}
-void RemovableDeviceNotificationsCros::DiskChanged(
- disks::DiskMountManagerEventType event,
+void RemovableDeviceNotificationsCros::OnDiskEvent(
+ disks::DiskMountManager::DiskEvent event,
const disks::DiskMountManager::Disk* disk) {
}
-void RemovableDeviceNotificationsCros::DeviceChanged(
- disks::DiskMountManagerEventType event,
+void RemovableDeviceNotificationsCros::OnDeviceEvent(
+ disks::DiskMountManager::DeviceEvent event,
const std::string& device_path) {
}
-void RemovableDeviceNotificationsCros::MountCompleted(
- disks::DiskMountManager::MountEvent event_type,
+void RemovableDeviceNotificationsCros::OnMountEvent(
+ disks::DiskMountManager::MountEvent event,
MountError error_code,
const disks::DiskMountManager::MountPointInfo& mount_info) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -145,7 +145,7 @@ void RemovableDeviceNotificationsCros::MountCompleted(
if (mount_info.mount_condition != disks::MOUNT_CONDITION_NONE)
return;
- switch (event_type) {
+ switch (event) {
case disks::DiskMountManager::MOUNTING: {
if (ContainsKey(mount_map_, mount_info.mount_path)) {
NOTREACHED();
@@ -171,6 +171,12 @@ void RemovableDeviceNotificationsCros::MountCompleted(
}
}
+void RemovableDeviceNotificationsCros::OnFormatEvent(
+ disks::DiskMountManager::FormatEvent event,
+ FormatError error_code,
+ const std::string& device_path) {
+}
+
bool RemovableDeviceNotificationsCros::GetDeviceInfoForPath(
const FilePath& path,
SystemMonitor::RemovableStorageInfo* device_info) const {

Powered by Google App Engine
This is Rietveld 408576698