Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/chromeos/imageburner/burn_controller.cc

Issue 11365142: Small refactoring in DiskMountManager (event reporting; format method). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: few lint nits Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/imageburner/burn_controller.cc
diff --git a/chrome/browser/chromeos/imageburner/burn_controller.cc b/chrome/browser/chromeos/imageburner/burn_controller.cc
index 33991e36b1df92c9d954d092363e72227f19249e..cef84d983ff2dc8a1e596a58aee0f0303c460650 100644
--- a/chrome/browser/chromeos/imageburner/burn_controller.cc
+++ b/chrome/browser/chromeos/imageburner/burn_controller.cc
@@ -64,29 +64,33 @@ class BurnControllerImpl
}
// disks::DiskMountManager::Observer interface.
- virtual void DiskChanged(disks::DiskMountManagerEventType event,
- const disks::DiskMountManager::Disk* disk)
- OVERRIDE {
+ virtual void OnDiskEvent(disks::DiskMountManager::DiskEvent event,
+ const disks::DiskMountManager::Disk* disk) OVERRIDE {
if (!IsBurnableDevice(*disk))
return;
- if (event == disks::MOUNT_DISK_ADDED) {
+ if (event == disks::DiskMountManager::DISK_ADDED) {
delegate_->OnDeviceAdded(*disk);
- } else if (event == disks::MOUNT_DISK_REMOVED) {
+ } else if (event == disks::DiskMountManager::DISK_REMOVED) {
delegate_->OnDeviceRemoved(*disk);
if (burn_manager_->target_device_path().value() == disk->device_path())
ProcessError(IDS_IMAGEBURN_DEVICE_NOT_FOUND_ERROR);
}
}
- virtual void DeviceChanged(disks::DiskMountManagerEventType event,
+ virtual void OnDeviceEvent(disks::DiskMountManager::DeviceEvent event,
const std::string& device_path) OVERRIDE {
}
- virtual void MountCompleted(
- disks::DiskMountManager::MountEvent event_type,
+ virtual void OnMountEvent(
+ disks::DiskMountManager::MountEvent event,
MountError error_code,
- const disks::DiskMountManager::MountPointInfo& mount_info)
- OVERRIDE {
+ const disks::DiskMountManager::MountPointInfo& mount_info) OVERRIDE {
+ }
+
+ virtual void OnFormatEvent(
+ disks::DiskMountManager::FormatEvent event,
+ FormatError error_code,
+ const std::string& device_path) OVERRIDE {
}
// BurnLibrary::Observer interface.

Powered by Google App Engine
This is Rietveld 408576698