Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: chrome/browser/chromeos/extensions/file_browser_event_router.h

Issue 11365142: Small refactoring in DiskMountManager (event reporting; format method). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: few lint nits Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_browser_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_browser_event_router.h
diff --git a/chrome/browser/chromeos/extensions/file_browser_event_router.h b/chrome/browser/chromeos/extensions/file_browser_event_router.h
index dc4cd5ec18f5603f264ec72d0ead2e0113eb9126..f3886a1b867cefa065aa6bccad1b23cf52909e8e 100644
--- a/chrome/browser/chromeos/extensions/file_browser_event_router.h
+++ b/chrome/browser/chromeos/extensions/file_browser_event_router.h
@@ -62,16 +62,21 @@ class FileBrowserEventRouter
void MountDrive(const base::Closure& callback);
// CrosDisksClient::Observer overrides.
- virtual void DiskChanged(chromeos::disks::DiskMountManagerEventType event,
- const chromeos::disks::DiskMountManager::Disk* disk)
- OVERRIDE;
- virtual void DeviceChanged(chromeos::disks::DiskMountManagerEventType event,
- const std::string& device_path) OVERRIDE;
- virtual void MountCompleted(
- chromeos::disks::DiskMountManager::MountEvent event_type,
+ virtual void OnDiskEvent(
+ chromeos::disks::DiskMountManager::DiskEvent event,
+ const chromeos::disks::DiskMountManager::Disk* disk) OVERRIDE;
+ virtual void OnDeviceEvent(
+ chromeos::disks::DiskMountManager::DeviceEvent event,
+ const std::string& device_path) OVERRIDE;
+ virtual void OnMountEvent(
+ chromeos::disks::DiskMountManager::MountEvent event,
chromeos::MountError error_code,
const chromeos::disks::DiskMountManager::MountPointInfo& mount_info)
OVERRIDE;
+ virtual void OnFormatEvent(
+ chromeos::disks::DiskMountManager::FormatEvent event,
+ chromeos::FormatError error_code,
+ const std::string& device_path) OVERRIDE;
// chromeos::NetworkLibrary::NetworkManagerObserver override.
virtual void OnNetworkManagerChanged(
@@ -158,8 +163,8 @@ class FileBrowserEventRouter
void OnDeviceAdded(const std::string& device_path);
void OnDeviceRemoved(const std::string& device_path);
void OnDeviceScanned(const std::string& device_path);
- void OnFormattingStarted(const std::string& device_path, bool success);
- void OnFormattingFinished(const std::string& device_path, bool success);
+ void OnFormatStarted(const std::string& device_path, bool success);
+ void OnFormatCompleted(const std::string& device_path, bool success);
// Process file watch notifications.
void HandleFileWatchNotification(const FilePath& path,
@@ -173,7 +178,7 @@ class FileBrowserEventRouter
void DispatchDiskEvent(const chromeos::disks::DiskMountManager::Disk* disk,
bool added);
- void DispatchMountCompletedEvent(
+ void DispatchMountEvent(
chromeos::disks::DiskMountManager::MountEvent event,
chromeos::MountError error_code,
const chromeos::disks::DiskMountManager::MountPointInfo& mount_info);
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_browser_event_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698