Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 11365140: Disabling failing/crash webkit_unit_tests (Closed)

Created:
8 years, 1 month ago by Ramya
Modified:
8 years, 1 month ago
Reviewers:
Yaron, Xianzhu
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Disabling failing/crash webkit_unit_tests BUG=159935 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A build/android/gtest_filter/webkit_unit_tests_disabled View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ramya
8 years, 1 month ago (2012-11-07 23:39:35 UTC) #1
Xianzhu
lgtm, but you still need an approval from a full committer.
8 years, 1 month ago (2012-11-07 23:46:31 UTC) #2
Peter Beverloo
LGTM. Since this is upstream infrastructure, we should be much stricter about when to disable ...
8 years, 1 month ago (2012-11-07 23:48:54 UTC) #3
Ramya
These tests have been constantly failing on the Android Webkit bot. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28GalaxyNexus%29/builds/983/steps/webkit_unit_tests/logs/stdio
8 years, 1 month ago (2012-11-07 23:52:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/11365140/1
8 years, 1 month ago (2012-11-07 23:52:46 UTC) #5
Peter Beverloo
On 2012/11/07 23:52:31, Ramya wrote: > These tests have been constantly failing on the Android ...
8 years, 1 month ago (2012-11-08 00:04:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/11365140/1
8 years, 1 month ago (2012-11-08 11:39:28 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-08 12:21:19 UTC) #8
Change committed as 166665

Powered by Google App Engine
This is Rietveld 408576698