Android: Fix invocations of TestResult.LogFull

Android: Fix invocations of TestResult.LogFull

Also remove the tests_to_run output from summay if we do not have the list of tests.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166602

[frankf, 2012-11-07 19:14:32]

LGTM with nit.

http://codereview.chromium.org/11365134/diff/1/build/android/pylib/test_resul...
File build/android/pylib/test_result.py (right):

http://codereview.chromium.org/11365134/diff/1/build/android/pylib/test_resul...
build/android/pylib/test_result.py:180: if len(tests_to_run) != 0:
if tests_to_run:

http://codereview.chromium.org/11365134/diff/1/build/android/pylib/test_resul...
build/android/pylib/test_result.py:193: if len(tests_to_run) != 0 and
num_tests_ran != len(tests_to_run):
same here.

[Isaac (away), 2012-11-07 19:17:21]

Why are we disabling this check on monkey tests?  Can we pass 'available_tests'
instead of the empty list?

[nilesh, 2012-11-07 19:28:57]

Using available_tests.

http://codereview.chromium.org/11365134/diff/1/build/android/pylib/test_resul...
File build/android/pylib/test_result.py (right):

http://codereview.chromium.org/11365134/diff/1/build/android/pylib/test_resul...
build/android/pylib/test_result.py:180: if len(tests_to_run) != 0:
On 2012/11/07 19:14:32, frankf wrote:
> if tests_to_run:

Done.

http://codereview.chromium.org/11365134/diff/1/build/android/pylib/test_resul...
build/android/pylib/test_result.py:193: if len(tests_to_run) != 0 and
num_tests_ran != len(tests_to_run):
On 2012/11/07 19:14:32, frankf wrote:
> same here.

Done.

[Isaac (away), 2012-11-07 19:32:37]

http://codereview.chromium.org/11365134/diff/8001/build/android/pylib/test_re...
File build/android/pylib/test_result.py (right):

http://codereview.chromium.org/11365134/diff/8001/build/android/pylib/test_re...
build/android/pylib/test_result.py:180: if tests_to_run:
I think we can remove these checks now that we are passing the actual list of
tests.

[nilesh, 2012-11-07 19:35:26]

http://codereview.chromium.org/11365134/diff/8001/build/android/pylib/test_re...
File build/android/pylib/test_result.py (right):

http://codereview.chromium.org/11365134/diff/8001/build/android/pylib/test_re...
build/android/pylib/test_result.py:180: if tests_to_run:
Actual list of tests is not passed from run_instrumentation_tests. We pass an
empty list there and this output is misleading. Also when a gtest_filter is
specified we do not have the list of unittests to run.

[Isaac (away), 2012-11-07 19:41:37]

k, lets file a bug to fix the run_instrumentation_test case.

[nilesh, 2012-11-08 00:09:58]

Created bug: crbug.com/159952

[Yaron, 2012-11-08 00:59:14]

lgtm

[commit-bot: I haz the power, 2012-11-08 00:59:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/11365134/8001

[Isaac (away), 2012-11-08 01:01:16]

lgTM

[commit-bot: I haz the power, 2012-11-08 04:39:10]

Change committed as 166602