LayoutTests/http/tests/push_messaging/permission-state-exception-in-document.html - Issue 1136513002: Reject permissonState calls if userVisible is not present as parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/push_messaging/permission-state-exception-in-document.html

Issue 1136513002: Reject permissonState calls if userVisible is not present as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/push_messaging/permission-state-denied-in-service-worker.html ('k') | LayoutTests/http/tests/push_messaging/permission-state-exception-in-service-worker.html » ('j') | Source/modules/push_messaging/PushManager.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/push_messaging/permission-state-exception-in-document.html

diff --git a/LayoutTests/http/tests/push_messaging/permission-state-prompt-in-document.html b/LayoutTests/http/tests/push_messaging/permission-state-exception-in-document.html

similarity index 59%

copy from LayoutTests/http/tests/push_messaging/permission-state-prompt-in-document.html

copy to LayoutTests/http/tests/push_messaging/permission-state-exception-in-document.html

index 77dd09b03b8cd85634fa05ea3dc009d9aeacc02e..2daa10d1ccea8539855f6f3d486b10edf9a8a190 100644

--- a/LayoutTests/http/tests/push_messaging/permission-state-prompt-in-document.html

+++ b/LayoutTests/http/tests/push_messaging/permission-state-exception-in-document.html

@@ -1,7 +1,7 @@

<!DOCTYPE html>

<html>

<head>

-<title>Push API: permissionState resolves with prompt when no permission is set</title>

+<title>Push API: permissionState fails with NotSupportedError if userVisibleOnly is not used</title>

@@ -21,11 +21,14 @@ async_test(function(test) {

return serviceWorkerRegistration.pushManager.permissionState();

})

.then(function(permissionStatus) {

- assert_equals(permissionStatus, 'prompt');

- return service_worker_unregister_and_done(test, workerScope);

- })

- .catch(unreached_rejection(test));

-}, 'Push API: permissionState() resolves with prompt when permission is not set');

+ assert_unreached('permissionStatus should have failed with a NotSupported exception');

+ }, function(error) {

+ assert_equals(error.name, 'NotSupportedError');

+ assert_equals(error.message,

+ 'Chrome does not support push subscriptions that do not enable the userVisibleOnly option.');

+ test.done();

+ }).catch(unreached_rejection(test));

+}, 'Push API: permissionState fails with NotSupportedError if userVisibleOnly is not used');

</script>

</body>

</html>