Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js

Issue 1136513002: Reject permissonState calls if userVisible is not present as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js
diff --git a/LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js b/LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js
index c6f5fbc1168b7d24e687c2ce8a5c92f5a826fb6a..7fc64d7b9f989703a0e66fa636baa02e1ba2282b 100644
--- a/LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js
+++ b/LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js
@@ -13,10 +13,10 @@ self.addEventListener('message', function(workerEvent) {
port.onmessage = function(event) {
if (typeof event.data != 'object' || !event.data.command)
return;
-
+ var arguments = event.data.arg || {}
Peter Beverloo 2015/05/07 15:28:21 Please also pass the |options| argument to subscri
Peter Beverloo 2015/05/07 15:28:21 s/(arguments|arg)/options/
Miguel Garcia 2015/05/07 19:40:46 Done.
Miguel Garcia 2015/05/07 19:40:46 Done.
switch (event.data.command) {
case 'permissionState':
- self.registration.pushManager.permissionState().then(function(permissionStatus) {
+ self.registration.pushManager.permissionState(arguments).then(function(permissionStatus) {
port.postMessage({ command: event.data.command,
success: true,
permission: permissionStatus });

Powered by Google App Engine
This is Rietveld 408576698