LayoutTests/http/tests/push_messaging/permission-state-prompt-in-document.html - Issue 1136513002: Reject permissonState calls if userVisible is not present as parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/push_messaging/permission-state-prompt-in-document.html

Issue 1136513002: Reject permissonState calls if userVisible is not present as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/push_messaging/permission-state-granted-in-document.html ('K') | « LayoutTests/http/tests/push_messaging/permission-state-granted-in-service-worker.html ('k') | LayoutTests/http/tests/push_messaging/permission-state-prompt-in-service-worker.html » ('j') | LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/push_messaging/permission-state-prompt-in-document.html

diff --git a/LayoutTests/http/tests/push_messaging/permission-state-prompt-in-document.html b/LayoutTests/http/tests/push_messaging/permission-state-prompt-in-document.html

index 77dd09b03b8cd85634fa05ea3dc009d9aeacc02e..3ed2b81113c55b73d08b79e4156911b696b548c3 100644

--- a/LayoutTests/http/tests/push_messaging/permission-state-prompt-in-document.html

+++ b/LayoutTests/http/tests/push_messaging/permission-state-prompt-in-document.html

@@ -18,7 +18,7 @@ async_test(function(test) {

service_worker_unregister_and_register(test, workerUrl, workerScope)

.then(function(serviceWorkerRegistration) {

// If running manually, clear permissions before running this test.

- return serviceWorkerRegistration.pushManager.permissionState();

+ return serviceWorkerRegistration.pushManager.permissionState({userVisibleOnly : true});

Peter Beverloo 2015/05/07 15:28:21 dito re: space before the colon.

Miguel Garcia 2015/05/07 19:40:46 Done.

})

.then(function(permissionStatus) {

assert_equals(permissionStatus, 'prompt');