Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2528)

Unified Diff: build/isolate.gypi

Issue 11365087: Disable isolate_dependency_tracked in build driver for .isolate files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: typo Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/isolate.gypi
diff --git a/build/isolate.gypi b/build/isolate.gypi
index f31dce9a8091296b915bca7c5cd80949bd78cf30..8f5d71a8604073bade347cb2783e82c39c9915a1 100644
--- a/build/isolate.gypi
+++ b/build/isolate.gypi
@@ -40,8 +40,18 @@
'rule_name': 'isolate',
'extension': 'isolate',
'inputs': [
- '<@(isolate_dependency_tracked)',
'<(RULE_INPUT_PATH)',
+ # Disable file tracking by the build driver for now. This means the
+ # project must have the proper build-time dependency for their runtime
+ # dependency. This improves the runtime of the build driver since it
+ # doesn't have to stat() all these files.
+ #
+ # More importantly, it means that even if a isolate_dependency_tracked
+ # file is missing, for example if a file was deleted and the .isolate
+ # file was not updated, that won't break the build, especially in the
+ # case where foo_tests_run is not built! This should be reenabled once
+ # the switch-over to running tests on Swarm is completed.
+ #'<@(isolate_dependency_tracked)',
],
'outputs': [
'<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).isolated',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698