Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 11365075: alternate ntp: tweaks and fixes for bookmark bar in ntp (Closed)

Created:
8 years, 1 month ago by kuan
Modified:
8 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, dhollowa+watch_chromium.org, arv (Not doing code reviews), estade+watch_chromium.org, tfarina
Visibility:
Public.

Description

alternate ntp: tweaks and fixes for bookmark bar in ntp - change bmb height to 48 - paint separator above bmb with different colors for standard and theme - bmb background * if theme is used, paint theme background color at max 80% opacity * otherwise, use transparent background - only show bmb when at least a row of "Most Visited" thumbnails is shown - don't show instruction bmb - fix new tab css to let content view show entire theme background image with no vertical offset, 'cos floating detached bmb doesn't show any part of the image - fix to paint separator below bmb after a suggestion is committed BUG=158944 TEST=verify per bug rpt Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -26 lines) Patch
M chrome/browser/resources/ntp_search/tile_page.js View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/search/search_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/detachable_toolbar_view.h View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/detachable_toolbar_view.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 4 chunks +28 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 5 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kuan
this cl has multiple tweaks and fixes, all detailed in cl description. sky, pls look ...
8 years, 1 month ago (2012-11-02 23:16:18 UTC) #1
kuan
evan, pls look at ntp_resource_cache.cc. thx.
8 years, 1 month ago (2012-11-02 23:16:44 UTC) #2
Evan Stade
lgtm
8 years, 1 month ago (2012-11-03 00:46:37 UTC) #3
sky
LGTM
8 years, 1 month ago (2012-11-05 15:22:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/11365075/1
8 years, 1 month ago (2012-11-05 15:48:02 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-05 18:24:03 UTC) #6
Change committed as 165963

Powered by Google App Engine
This is Rietveld 408576698