Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11365055: Initial braille support (Closed)

Created:
8 years, 1 month ago by David Trainor- moved to gerrit
Modified:
8 years ago
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Initial braille support Connect third_party/eyesfree code to Chrome, allowing accessibility to interact with a braille keyboard. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173099

Patch Set 1 #

Patch Set 2 : Updated usage #

Patch Set 3 : Remove unnecessary files #

Total comments: 3

Patch Set 4 : Updated gyp file to work with actual checkout. #

Patch Set 5 : Clean up gyp, add android OS condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -29 lines) Patch
M build/java_aidl.gypi View 4 chunks +17 lines, -0 lines 0 comments Download
M content/content.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java View 1 5 chunks +31 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/CommandLine.java View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/eyesfree/eyesfree.gyp View 1 2 3 4 1 chunk +36 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
David Trainor- moved to gerrit
PTAL. Once my other CL lands that adds the gyp file, I can get an ...
8 years ago (2012-12-08 09:34:17 UTC) #1
David Trainor- moved to gerrit
Adding Jay as Ted is extremely busy this week. Jay can you PTAL?
8 years ago (2012-12-10 22:12:38 UTC) #2
Jay Civelli
lgtm https://chromiumcodereview.appspot.com/11365055/diff/5001/content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java File content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java (right): https://chromiumcodereview.appspot.com/11365055/diff/5001/content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java#newcode262 content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java:262: mTextToSpeech = new TextToSpeechWrapper(mContentViewCore.getContainerView(), Why are you not ...
8 years ago (2012-12-10 22:21:53 UTC) #3
David Trainor- moved to gerrit
https://chromiumcodereview.appspot.com/11365055/diff/5001/content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java File content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java (right): https://chromiumcodereview.appspot.com/11365055/diff/5001/content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java#newcode262 content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java:262: mTextToSpeech = new TextToSpeechWrapper(mContentViewCore.getContainerView(), On 2012/12/10 22:21:54, Jay Civelli ...
8 years ago (2012-12-10 22:30:24 UTC) #4
Jay Civelli
lgtm https://chromiumcodereview.appspot.com/11365055/diff/5001/content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java File content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java (right): https://chromiumcodereview.appspot.com/11365055/diff/5001/content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java#newcode262 content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java:262: mTextToSpeech = new TextToSpeechWrapper(mContentViewCore.getContainerView(), On 2012/12/10 22:30:24, dtrainor ...
8 years ago (2012-12-10 22:59:39 UTC) #5
David Trainor- moved to gerrit
Hey John, can you please take a look at the content/content.gyp file? I need an ...
8 years ago (2012-12-13 23:21:48 UTC) #6
jam
On 2012/12/13 23:21:48, dtrainor wrote: > Hey John, can you please take a look at ...
8 years ago (2012-12-13 23:22:13 UTC) #7
David Trainor- moved to gerrit
Shashi, just realized you might want to look at java_aidl changes before I land. Can ...
8 years ago (2012-12-13 23:41:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/11365055/16001
8 years ago (2012-12-14 00:41:09 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-14 05:58:13 UTC) #10
Message was sent while issue was closed. 
Change committed as 173099

Powered by Google App Engine
This is Rietveld 408576698