Issue 11365046: Redirect behaviour of gesture events on browser action buttons appropriately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11365046: Redirect behaviour of gesture events on browser action buttons appropriately. (Closed)

Created:
8 years, 1 month ago by flackr

Modified:
8 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Redirect behaviour of gesture events on browser action buttons appropriately. BUG=151364 TEST=Install Speedtracer, tap icon in toolbar. Speedtracer window opens up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166012

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix style. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	chrome/browser/ui/views/browser_action_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/browser_action_view.cc	View	1	2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/11365046/diff/1/chrome/browser/ui/views/browser_action_view.cc File chrome/browser/ui/views/browser_action_view.cc (right): https://codereview.chromium.org/11365046/diff/1/chrome/browser/ui/views/browser_action_view.cc#newcode350 chrome/browser/ui/views/browser_action_view.cc:350: : TextButton::OnGestureEvent(event); : should be on the previous ...

8 years, 1 month ago (2012-11-01 21:50:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/11365046/4001

8 years, 1 month ago (2012-11-05 17:39:40 UTC) #3

Change committed as 166012

Expand Messages | Collapse Messages