Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 11365044: Run findbugs and findbugs-plugin test on clang bot. (Closed)

Created:
8 years, 1 month ago by michaelbai
Modified:
8 years, 1 month ago
Reviewers:
bulach, Yaron, Isaac (away)
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Run findbugs and findbugs-plugin test on clang bot. - Also rebaseline the known bugs. BUG=156116 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165848

Patch Set 1 #

Patch Set 2 : Also add to try bot #

Patch Set 3 : sync #

Total comments: 2

Patch Set 4 : addressed comments #

Patch Set 5 : Rebaseline, move to tester bots. #

Patch Set 6 : Move to fyi builder #

Patch Set 7 : rebaseline again #

Patch Set 8 : Remove the classes which not upstreamed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -7 lines) Patch
M build/android/buildbot/bb_fyi_builder.sh View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/buildbot/buildbot_functions.sh View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 2 3 4 5 6 7 9 chunks +35 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
michaelbai
8 years, 1 month ago (2012-11-01 20:58:51 UTC) #1
Yaron
Looks like this failed for your tryjob. http://codereview.chromium.org/11365044/diff/9002/build/android/buildbot/buildbot_functions.sh File build/android/buildbot/buildbot_functions.sh (right): http://codereview.chromium.org/11365044/diff/9002/build/android/buildbot/buildbot_functions.sh#newcode222 build/android/buildbot/buildbot_functions.sh:222: build/android/findbugs_diff.py Both ...
8 years, 1 month ago (2012-11-02 00:09:47 UTC) #2
michaelbai
It seemed the try bot run on the wrong revision http://codereview.chromium.org/11365044/diff/9002/build/android/buildbot/buildbot_functions.sh File build/android/buildbot/buildbot_functions.sh (right): http://codereview.chromium.org/11365044/diff/9002/build/android/buildbot/buildbot_functions.sh#newcode222 ...
8 years, 1 month ago (2012-11-02 00:31:19 UTC) #3
Yaron
Still coming up red. lgtm if you update expectations and put it through cq
8 years, 1 month ago (2012-11-02 02:29:38 UTC) #4
Isaac (away)
Please do not submit. I am moving clang onto CQ (likely tomorrow) and it would ...
8 years, 1 month ago (2012-11-02 02:50:24 UTC) #5
Isaac (away)
Is there any reason this has to land on the clang bot? If not, please ...
8 years, 1 month ago (2012-11-02 05:09:19 UTC) #6
michaelbai
On 2012/11/02 05:09:19, Isaac wrote: > Is there any reason this has to land on ...
8 years, 1 month ago (2012-11-02 05:13:01 UTC) #7
Isaac (away)
K. Please put on fyi and fyi try bot and we can move to main ...
8 years, 1 month ago (2012-11-02 06:22:22 UTC) #8
bulach
just to clarify the clang x findbugs: we were sharing the same bot downstream just ...
8 years, 1 month ago (2012-11-02 12:42:24 UTC) #9
michaelbai
Moved to fyi bot, how to do try fyi bot?
8 years, 1 month ago (2012-11-02 20:14:40 UTC) #10
michaelbai
Moved to fyi_builder
8 years, 1 month ago (2012-11-02 20:26:40 UTC) #11
Isaac (away)
lgtm
8 years, 1 month ago (2012-11-02 21:36:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11365044/5011
8 years, 1 month ago (2012-11-02 22:49:49 UTC) #13
commit-bot: I haz the power
Retried try job too often for step(s) content_browsertests
8 years, 1 month ago (2012-11-03 02:32:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11365044/5011
8 years, 1 month ago (2012-11-03 03:31:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11365044/5011
8 years, 1 month ago (2012-11-03 03:33:12 UTC) #16
commit-bot: I haz the power
8 years, 1 month ago (2012-11-03 07:10:34 UTC) #17
Change committed as 165848

Powered by Google App Engine
This is Rietveld 408576698