Issue 11365041: [Sync] Re-reland fix for bug 154940

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11365041: [Sync] Re-reland fix for bug 154940 (Closed)

Created:
8 years, 1 month ago by Nicolas Zea

Modified:
8 years ago

Reviewers:

CC:
chromium-reviews, Raghu Simha, haitaol1, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Re-reland fix for bug 154940 Speculatively fixed test by making syncer::UserTypes() stack allocated at a higher scope, instead of within the for loop. I suspect on certain windows builds the for loop allocation was being dealloc'd early, hence invalidating the iterator. Original codereview at http://codereview.chromium.org/11342022/ BUG=158391 TBR=tim@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165521

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -0 lines)			Patch
M	chrome/browser/sync/profile_sync_service.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	3 chunks	+38 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_startup_unittest.cc	View	2 chunks	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/11365041/1

8 years, 1 month ago (2012-11-01 20:13:26 UTC) #1

akalin

8 years ago (2012-11-26 21:20:16 UTC) #3

Message was sent while issue was closed.

On 2012/11/01 22:18:54, I haz the power (commit-bot) wrote:
> Change committed as 165521

Yeah, your speculative fix is a real fix.  I wish there were an easy way to
detect that case; there's a comment in enum_set.h warning against doing
SomeFun().First(), but it's easy to miss.

I considered WeakPtrs but that seemed too heavyweight. :/

Expand Messages | Collapse Messages