Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11365028: Calls default window procedure for WM_KILLFOCUS. (Closed)

Created:
8 years, 1 month ago by Seigo Nonaka
Modified:
8 years, 1 month ago
Reviewers:
yukawa, sky
CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Calls default window procedure for WM_KILLFOCUS. Without default window procedure, the actual focus does not change correctly. BUG=158562 TEST=Manually done Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165629

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/controls/textfield/native_textfield_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Seigo Nonaka
8 years, 1 month ago (2012-11-01 04:35:21 UTC) #1
Yohei Yukawa
lgtm
8 years, 1 month ago (2012-11-01 04:36:45 UTC) #2
Seigo Nonaka
Thank you. Adding sky@ as the owner of ui/views.
8 years, 1 month ago (2012-11-01 04:40:16 UTC) #3
sky
LGTM https://codereview.chromium.org/11365028/diff/1/ui/views/controls/textfield/native_textfield_win.cc File ui/views/controls/textfield/native_textfield_win.cc (right): https://codereview.chromium.org/11365028/diff/1/ui/views/controls/textfield/native_textfield_win.cc#newcode1070 ui/views/controls/textfield/native_textfield_win.cc:1070: SetMsgHandled(FALSE); Move this to the end like we ...
8 years, 1 month ago (2012-11-01 16:00:37 UTC) #4
Seigo Nonaka
Thank you your review! Submitting... http://codereview.chromium.org/11365028/diff/1/ui/views/controls/textfield/native_textfield_win.cc File ui/views/controls/textfield/native_textfield_win.cc (right): http://codereview.chromium.org/11365028/diff/1/ui/views/controls/textfield/native_textfield_win.cc#newcode1070 ui/views/controls/textfield/native_textfield_win.cc:1070: SetMsgHandled(FALSE); On 2012/11/01 16:00:37, ...
8 years, 1 month ago (2012-11-02 02:11:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11365028/6001
8 years, 1 month ago (2012-11-02 02:11:49 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-02 05:50:40 UTC) #7 
Change committed as 165629

Powered by Google App Engine
This is Rietveld 408576698