Issue 11364204: FTP: fix compatibility with mod_ftp's LISTisNLST option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11364204: FTP: fix compatibility with mod_ftp's LISTisNLST option. (Closed)

Created:
8 years, 1 month ago by Paweł Hajdan Jr.

Modified:
8 years, 1 month ago

Reviewers:
mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

FTP: fix compatibility with mod_ftp's LISTisNLST option. We can't unambiguously parse NLST listing (just file names, but they might have spaces, which might end up looking just like some other listing format), so we need to force a "proper" listing. It turns out issuing "LIST -l" command does so for mod_ftp, and is hopefully harmless for other servers. BUG=76999 TEST=Covered by net_unittests, also see bug for manual testing with mod_ftp. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167256

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	net/ftp/ftp_network_transaction.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	net/ftp/ftp_network_transaction_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/11364204/1

8 years, 1 month ago (2012-11-12 22:21:39 UTC) #3

Change committed as 167256

Expand Messages | Collapse Messages