Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 11364202: Get full WebPluginInfo for the PDF plug-in before enabling it for print preview. (Closed)

Created:
8 years, 1 month ago by Bernhard Bauer
Modified:
8 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Get full WebPluginInfo for the PDF plug-in before enabling it for print preview. BUG=159902 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167487

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Total comments: 2

Patch Set 5 : fix #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : fix!!! #

Patch Set 9 : fix? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -31 lines) Patch
M chrome/browser/printing/print_preview_tab_controller.cc View 1 2 3 4 5 6 7 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -0 lines 0 comments Download
M ui/base/win/window_impl.cc View 1 2 3 4 5 6 7 8 4 chunks +7 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bernhard Bauer
Please review.
8 years, 1 month ago (2012-11-12 19:48:09 UTC) #1
Lei Zhang
The try bots do not seem happy with this change. http://codereview.chromium.org/11364202/diff/4012/chrome/browser/printing/print_preview_tab_controller.cc File chrome/browser/printing/print_preview_tab_controller.cc (right): http://codereview.chromium.org/11364202/diff/4012/chrome/browser/printing/print_preview_tab_controller.cc#newcode61 ...
8 years, 1 month ago (2012-11-12 21:27:52 UTC) #2
Bernhard Bauer
Blergh, tests are hard. PTAL? https://codereview.chromium.org/11364202/diff/4012/chrome/browser/printing/print_preview_tab_controller.cc File chrome/browser/printing/print_preview_tab_controller.cc (right): https://codereview.chromium.org/11364202/diff/4012/chrome/browser/printing/print_preview_tab_controller.cc#newcode61 chrome/browser/printing/print_preview_tab_controller.cc:61: PathService::Get(chrome::FILE_PDF_PLUGIN, &pdf_plugin_path); On 2012/11/12 ...
8 years, 1 month ago (2012-11-13 18:06:38 UTC) #3
Lei Zhang
lgtm
8 years, 1 month ago (2012-11-13 20:13:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/11364202/13002
8 years, 1 month ago (2012-11-13 20:39:34 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-13 22:24:28 UTC) #6
Change committed as 167487

Powered by Google App Engine
This is Rietveld 408576698