Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 11364168: Add a workaround for crbug.com/139556. (Closed)

Created:
8 years, 1 month ago by Yusuke Sato
Modified:
8 years, 1 month ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add a workaround for crbug.com/139556. * Switch to the next IME when Shift+Alt+Enter (or Space) are pressed and then Enter (or Space) is released. Since most of CJK IMEs use either Enter or Space as a "commit" key, this should work fine for such IME users. * The workaround might not be good enough for Cangjie/Quick IME users since the IME also uses [0-9] keys for committing a string. We might have to add additional workaround for switching from a keyboard layout to an IME, but I believe this CL would be a good enough as an initial trial. BUG=139556 TEST=added some new ash_unittests. also manually checked that the key repeat suppression change by mtomasz is still working fine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166868

Patch Set 1 #

Patch Set 2 : removed unused var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -25 lines) Patch
M ash/accelerators/accelerator_controller.h View 1 1 chunk +9 lines, -9 lines 0 comments Download
M ash/accelerators/accelerator_controller.cc View 3 chunks +15 lines, -10 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 3 chunks +49 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
nona, let me add some workarounds for 139556. The current behavior is too frustrating to ...
8 years, 1 month ago (2012-11-09 01:13:14 UTC) #1
Seigo Nonaka
LGTM
8 years, 1 month ago (2012-11-09 03:39:24 UTC) #2
Yusuke Sato
+derat for owners review.
8 years, 1 month ago (2012-11-09 03:58:36 UTC) #3
Daniel Erat
lgtm
8 years, 1 month ago (2012-11-09 04:57:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/11364168/1004
8 years, 1 month ago (2012-11-09 05:04:59 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-09 06:58:14 UTC) #6
Change committed as 166868

Powered by Google App Engine
This is Rietveld 408576698