Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11364134: Merge libv1. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart
Patch Set: Reupload due to error Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/create_sdk.py ('k') | utils/apidoc/apidoc.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index c47a60867276c3c753d3e31cc6554c45ab0ce3d4..cf13237b266ecf3beaab7817db1a53eaca2ed74d 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -407,6 +407,11 @@ class StandardTestSuite implements TestSuite {
}
Set<String> expectations = testExpectations.expectations(testName);
+ if (info.hasCompileError &&
+ TestUtils.isBrowserRuntime(configuration['runtime'])) {
+ SummaryReport.addCompileErrorSkipTest();
+ return;
+ }
if (configuration['report']) {
// Tests with multiple VMOptions are counted more than once.
for (var dummy in getVmOptions(optionsFromFile)) {
@@ -1446,6 +1451,7 @@ class SummaryReport {
static int fail = 0;
static int crash = 0;
static int timeout = 0;
+ static int compileErrorSkip = 0;
static void add(Set<String> expectations) {
++total;
@@ -1474,6 +1480,11 @@ class SummaryReport {
}
}
+ static void addCompileErrorSkipTest() {
+ total++;
+ compileErrorSkip++;
+ }
+
static void printReport() {
if (total == 0) return;
String report = """Total: $total tests
@@ -1484,6 +1495,7 @@ class SummaryReport {
* $fail tests are expected to fail that we should fix
* $crash tests are expected to crash that we should fix
* $timeout tests are allowed to timeout
+ * $compileErrorSkip tests are skipped on browsers due to compile-time error
""";
print(report);
}
« no previous file with comments | « tools/create_sdk.py ('k') | utils/apidoc/apidoc.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698