Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/TaskProcessor.java

Issue 11364134: Merge libv1. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart
Patch Set: Reupload due to error Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/TaskProcessor.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/TaskProcessor.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/TaskProcessor.java
index b34a9f8141342c12bcbb6d741e6986504aebf67f..efab77c24f9c918eb82388461211e5659d4edbe7 100644
--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/TaskProcessor.java
+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/TaskProcessor.java
@@ -40,6 +40,12 @@ public class TaskProcessor {
private boolean isIdle = false;
/**
+ * An operation to be performed when the queue is empty and listeners have been notified that the
+ * receiver is idle. May be {@code null} if there is no idle operation.
+ */
+ private Runnable idleOperation;
+
+ /**
* A collection of objects to be notified when the receiver is idle. Synchronize against
* {@link #lock} before accessing this field.
*/
@@ -138,6 +144,16 @@ public class TaskProcessor {
}
/**
+ * Set the operation to be executed when the queue is empty and after all have been notified that
+ * the processor is idle. This operation should execute quickly to keep analysis responsive.
+ *
+ * @param task the task or {@code null} if none
+ */
+ public void setIdleOperation(Runnable runnable) {
+ idleOperation = runnable;
+ }
+
+ /**
* Start the background analysis process if it has not already been started. This background
* thread will process tasks from the associated event queue until the
* {@link TaskQueue#setAnalyzing(boolean)} method is called with a value of <code>false</code>.
@@ -174,6 +190,17 @@ public class TaskProcessor {
// Notify :: Changing state from Running to Idle
notifyIdle(true);
+ // Perform the idle operation if there is one
+ Runnable runnable = idleOperation;
+ if (runnable != null) {
+ try {
+ runnable.run();
+ } catch (Throwable e) {
+ idleOperation = null;
+ DartCore.logError("Idle Operation Exception", e);
+ }
+ }
+
// Idle :: Wait for new tasks on the queue... or analysis to be canceled
if (!queue.waitForTask()) {
break;

Powered by Google App Engine
This is Rietveld 408576698