Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: runtime/bin/builtin_natives.cc

Issue 11364134: Merge libv1. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart
Patch Set: Reupload due to error Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/builtin.dart ('k') | runtime/dart-runtime.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/builtin_natives.cc
diff --git a/runtime/bin/builtin_natives.cc b/runtime/bin/builtin_natives.cc
index 995207c3d2f749db2ad6f86281255af875b8e59e..68258c33d60446caaafd3c96e195ee4f0db1f8c7 100644
--- a/runtime/bin/builtin_natives.cc
+++ b/runtime/bin/builtin_natives.cc
@@ -103,17 +103,16 @@ Dart_NativeFunction Builtin::NativeLookup(Dart_Handle name,
// test/debug functionality in standalone dart mode.
void Builtin::PrintString(FILE* out, Dart_Handle str) {
- const char* chars = NULL;
-
- Dart_Handle result = Dart_StringToCString(str, &chars);
+ intptr_t length = 0;
+ uint8_t* chars = NULL;
+ Dart_Handle result = Dart_StringToUTF8(str, &chars, &length);
if (Dart_IsError(result)) {
// TODO(turnidge): Consider propagating some errors here. What if
// an isolate gets interrupted by the embedder in the middle of
- // Dart_StringToBytes? We need to make sure not to swallow the
+ // Dart_StringToUTF8? We need to make sure not to swallow the
// interrupt.
fputs(Dart_GetError(result), out);
} else {
- intptr_t length = strlen(chars);
fwrite(chars, sizeof(*chars), length, out);
}
fputc('\n', out);
« no previous file with comments | « runtime/bin/builtin.dart ('k') | runtime/dart-runtime.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698