Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/feedback/FeedbackSubmissionJob.java

Issue 11364134: Merge libv1. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart
Patch Set: Reupload due to error Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/feedback/FeedbackSubmissionJob.java
diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/feedback/FeedbackSubmissionJob.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/feedback/FeedbackSubmissionJob.java
index 4eb9823b780d7f785a18832093c6e081e85e9ee2..d572b9996e24182e29efac240d31a4de16d8551b 100644
--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/feedback/FeedbackSubmissionJob.java
+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/feedback/FeedbackSubmissionJob.java
@@ -152,18 +152,17 @@ public class FeedbackSubmissionJob extends Job {
private void submitFeedback(URL serverURL, IProgressMonitor monitor) throws IOException {
submitFeedback_text(serverURL, monitor);
if (OpenFeedbackDialogAction.SCREEN_CAPTURE_ENABLED) {
- submitFeedback_jpeg(serverURL, monitor);
+ if (writer.sendScreenshotData()) {
+ submitFeedback_png(serverURL, monitor);
+ }
}
}
- private int submitFeedback_jpeg(URL serverURL, IProgressMonitor monitor) throws IOException {
- if (!writer.sendScreenshotData()) {
- return 0;
- }
+ private int submitFeedback_png(URL serverURL, IProgressMonitor monitor) throws IOException {
byte[] data = writer.getImageByteArray();
monitor.beginTask(
- FeedbackMessages.FeedbackSubmissionJob_job_starting_progress_text_jpeg,
+ FeedbackMessages.FeedbackSubmissionJob_job_starting_progress_text_png,
data.length);
HttpURLConnection connection = (HttpURLConnection) serverURL.openConnection();
@@ -176,7 +175,7 @@ public class FeedbackSubmissionJob extends Job {
connection.setUseCaches(false);
connection.setAllowUserInteraction(false);
connection.setRequestProperty("Connection", "close"); //$NON-NLS-1$ //$NON-NLS-2$
- connection.setRequestProperty("Content-Type", "image/jpeg"); //$NON-NLS-1$ //$NON-NLS-2$
+ connection.setRequestProperty("Content-Type", "image/png"); //$NON-NLS-1$ //$NON-NLS-2$
DataOutputStream out = new DataOutputStream(connection.getOutputStream());

Powered by Google App Engine
This is Rietveld 408576698