Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 11364104: Tentatively reenable MediaTest.VideoTulipWebm on Mac. (Closed)

Created:
8 years, 1 month ago by scherkus (not reviewing)
Modified:
8 years, 1 month ago
Reviewers:
jam, DaleCurtis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Tentatively reenable MediaTest.VideoTulipWebm on Mac. The corresponding WebKit bug 94365 has been fixed and flakiness dashboard hasn't reported a recent failure. BUG=142896 TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166335

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M content/browser/media_browsertest.cc View 1 chunk +0 lines, -7 lines 3 comments Download

Messages

Total messages: 9 (0 generated)
scherkus (not reviewing)
8 years, 1 month ago (2012-11-06 21:53:14 UTC) #1
DaleCurtis
lgtm % q. http://codereview.chromium.org/11364104/diff/1/content/browser/media_browsertest.cc File content/browser/media_browsertest.cc (right): http://codereview.chromium.org/11364104/diff/1/content/browser/media_browsertest.cc#newcode42 content/browser/media_browsertest.cc:42: command_line->AppendSwitch(switches::kDisableAudio); I believe this can be ...
8 years, 1 month ago (2012-11-06 21:54:51 UTC) #2
scherkus (not reviewing)
http://codereview.chromium.org/11364104/diff/1/content/browser/media_browsertest.cc File content/browser/media_browsertest.cc (right): http://codereview.chromium.org/11364104/diff/1/content/browser/media_browsertest.cc#newcode42 content/browser/media_browsertest.cc:42: command_line->AppendSwitch(switches::kDisableAudio); On 2012/11/06 21:54:51, DaleCurtis wrote: > I believe ...
8 years, 1 month ago (2012-11-06 21:57:04 UTC) #3
DaleCurtis
https://codereview.chromium.org/11362121 also you'll need to TBR this against a content/ owner since this isn't in ...
8 years, 1 month ago (2012-11-06 22:20:20 UTC) #4
scherkus (not reviewing)
TBR=jam for content/
8 years, 1 month ago (2012-11-06 22:27:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/11364104/1
8 years, 1 month ago (2012-11-06 22:27:20 UTC) #6
jam
lgtm
8 years, 1 month ago (2012-11-07 01:20:02 UTC) #7
jam
also please add per-file owners for this test so you guys can be owners for ...
8 years, 1 month ago (2012-11-07 01:20:21 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-11-07 01:43:54 UTC) #9
Change committed as 166335

Powered by Google App Engine
This is Rietveld 408576698