Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: build/common.gypi

Issue 11364088: Pass -g1 on android release builds with fastbuild (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed gyp comment Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 8d3e18c5cefbd279c2035f2f2c637f6f10bf0ee1..69514bc36f3ec09b46da035eb5ea8d3ecdd994ab 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1613,35 +1613,57 @@
'defines': ['ENABLE_HIDPI=1'],
}],
['fastbuild!=0', {
-
+ # Clang creates chubby debug information, which makes linking very
+ # slow. For now, don't create debug information with clang. See
+ # http://crbug.com/70000
'conditions': [
- # For Windows and Mac, we don't genererate debug information.
- ['OS=="win" or OS=="mac"', {
- 'msvs_settings': {
- 'VCLinkerTool': {
- 'GenerateDebugInformation': 'false',
- },
- 'VCCLCompilerTool': {
- 'DebugInformationFormat': '0',
- }
- },
- 'xcode_settings': {
- 'GCC_GENERATE_DEBUGGING_SYMBOLS': 'NO',
- },
- }, { # else: OS != "win", generate less debug information.
- 'variables': {
- 'debug_extra_cflags': '-g1',
- },
- }],
- # Clang creates chubby debug information, which makes linking very
- # slow. For now, don't create debug information with clang. See
- # http://crbug.com/70000
- ['(OS=="linux" or OS=="android") and clang==1', {
- 'variables': {
- 'debug_extra_cflags': '-g0',
- },
- }],
- ], # conditions for fastbuild.
+ ['clang==1', {
+ 'conditions': [
+ ['OS=="linux"', {
+ 'variables': {
+ 'debug_extra_cflags': '-g0',
+ },
+ }],
+ # Android builds symbols on release by default, disable them.
+ ['OS=="android"', {
+ 'variables': {
+ 'debug_extra_cflags': '-g0',
+ 'release_extra_cflags': '-g0',
+ },
+ }],
+ ],
+ }, { # else clang!=1
+ 'conditions': [
+ # For Windows and Mac, we don't genererate debug information.
+ ['OS=="win"', {
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'GenerateDebugInformation': 'false',
+ },
+ 'VCCLCompilerTool': {
+ 'DebugInformationFormat': '0',
+ },
+ },
+ }],
+ ['OS=="mac"', {
+ 'xcode_settings': {
+ 'GCC_GENERATE_DEBUGGING_SYMBOLS': 'NO',
Nico 2013/04/24 05:23:45 Since clang is always ==1 on mac, this CL effectiv
Isaac (away) 2013/04/24 11:47:56 :-\ Glad it is getting fixed.
+ },
+ }],
+ ['OS=="linux"', {
+ 'variables': {
+ 'debug_extra_cflags': '-g1',
+ },
+ }],
+ ['OS=="android"', {
+ 'variables': {
+ 'debug_extra_cflags': '-g1',
+ 'release_extra_cflags': '-g1',
+ },
+ }],
+ ],
+ }], # clang!=1
+ ],
}], # fastbuild!=0
['dcheck_always_on!=0', {
'defines': ['DCHECK_ALWAYS_ON=1'],
@@ -2138,7 +2160,7 @@
['win_use_allocator_shim==0', {
'defines': ['NO_TCMALLOC'],
}],
- ['OS=="linux"', {
+ ['OS=="linux" or OS=="android"', {
'target_conditions': [
['_toolset=="target"', {
'cflags': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698