Issue 11364088: Pass -g1 on android release builds with fastbuild

Issue 11364088: Pass -g1 on android release builds with fastbuild (Closed)

Created:
8 years, 1 month ago by Isaac (away)

Modified:
7 years, 8 months ago

Reviewers:
cjhopman, Nico, Paweł Hajdan Jr.

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pass -g1 on android release builds with fastbuild Also reorganizing fastbuild section. NOTRY=True Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166076

Patch Set 2 : Fixed gyp comment #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -29 lines)			Patch
	M	build/common.gypi	View	1	2 chunks	+51 lines, -29 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

LGTM with a comment. https://chromiumcodereview.appspot.com/11364088/diff/1/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/11364088/diff/1/build/common.gypi#newcode1627 build/common.gypi:1627: # android builds symbols on ...

8 years, 1 month ago (2012-11-05 23:39:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11364088/4001

8 years, 1 month ago (2012-11-05 23:53:59 UTC) #3

Nico

(ukai is fixing) https://chromiumcodereview.appspot.com/11364088/diff/4001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/11364088/diff/4001/build/common.gypi#newcode1650 build/common.gypi:1650: 'GCC_GENERATE_DEBUGGING_SYMBOLS': 'NO', Since clang is always ...

7 years, 8 months ago (2013-04-24 05:23:45 UTC) #5

Isaac (away)

7 years, 8 months ago (2013-04-24 11:47:56 UTC) #6

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/11364088/diff/4001/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/11364088/diff/4001/build/common.gypi#n...
build/common.gypi:1650: 'GCC_GENERATE_DEBUGGING_SYMBOLS': 'NO',
On 2013/04/24 05:23:45, Nico wrote:
> Since clang is always ==1 on mac, this CL effectively broke fastbuild=1 for
mac.

:-\ Glad it is getting fixed.

Expand Messages | Collapse Messages