Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 11364031: remoting: Update calls froms RunAllPending() to RunUntilIdle(). (Closed)

Created:
8 years, 1 month ago by tfarina
Modified:
8 years, 1 month ago
Reviewers:
Sergey Ulanov, Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org, jbates
Visibility:
Public.

Description

remoting: Update calls froms RunAllPending() to RunUntilIdle(). BUG=131220 TEST=remoting_unittests R=sergeyu@chromium.org,wez@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -43 lines) Patch
M remoting/host/heartbeat_sender_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M remoting/host/host_key_pair_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/register_support_host_request_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/jingle_glue/iq_sender_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/buffered_socket_writer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/channel_multiplexer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/connection_to_client_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/message_reader_unittest.cc View 11 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Guys, please could you review this one for me? John, fyi.
8 years, 1 month ago (2012-11-01 20:12:56 UTC) #1
Sergey Ulanov
lgtm
8 years, 1 month ago (2012-11-01 20:16:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11364031/1
8 years, 1 month ago (2012-11-01 20:18:58 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-01 22:34:02 UTC) #4
Change committed as 165528

Powered by Google App Engine
This is Rietveld 408576698