Telemetry: adds dromaeo dom and jslib benchmarks.

Telemetry: adds dromaeo dom and jslib benchmarks.

As part of android upstreaming, we need to move those tests to Telemetry.

BUG=136699
TEST=./tools/perf/run_multipage_benchmarks --browser=system --show-stdout dromaeo tools/perf/page_sets/dromaeo_jslib.json


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169254

[bulach, 2012-11-15 19:24:20]

FYI nduca, tonyg

[bulach, 2012-11-21 10:26:29]

ping?

[tonyg, 2012-11-21 18:05:35]

https://codereview.chromium.org/11363232/diff/2001/tools/perf/perf_tools/drom...
File tools/perf/perf_tools/dromaeo.py (right):

https://codereview.chromium.org/11363232/diff/2001/tools/perf/perf_tools/drom...
tools/perf/perf_tools/dromaeo.py:10: js_is_done =
"""window.document.cookie.indexOf('__done=1') >= 0"""
This string should be singly quoted.

https://codereview.chromium.org/11363232/diff/2001/tools/perf/perf_tools/drom...
tools/perf/perf_tools/dromaeo.py:16: window.automation.GetScore()
I think you need to get the individual results for GetResults() in addition to
the summary from GetScore(). See chrome/test/perf/dromaeo_benchmark_uitest.cc.

https://codereview.chromium.org/11363232/diff/2001/tools/perf/perf_tools/drom...
tools/perf/perf_tools/dromaeo.py:17: """
This can be a single-line string.

[bulach, 2012-11-21 19:55:10]

thanks tony! all addressed, another look please?

https://codereview.chromium.org/11363232/diff/2001/tools/perf/perf_tools/drom...
File tools/perf/perf_tools/dromaeo.py (right):

https://codereview.chromium.org/11363232/diff/2001/tools/perf/perf_tools/drom...
tools/perf/perf_tools/dromaeo.py:10: js_is_done =
"""window.document.cookie.indexOf('__done=1') >= 0"""
On 2012/11/21 18:05:35, tonyg wrote:
> This string should be singly quoted.

Done.

https://codereview.chromium.org/11363232/diff/2001/tools/perf/perf_tools/drom...
tools/perf/perf_tools/dromaeo.py:16: window.automation.GetScore()
On 2012/11/21 18:05:35, tonyg wrote:
> I think you need to get the individual results for GetResults() in addition to
> the summary from GetScore(). See chrome/test/perf/dromaeo_benchmark_uitest.cc.

Done.

https://codereview.chromium.org/11363232/diff/2001/tools/perf/perf_tools/drom...
tools/perf/perf_tools/dromaeo.py:17: """
On 2012/11/21 18:05:35, tonyg wrote:
> This can be a single-line string.

Done.

[tonyg, 2012-11-21 20:11:44]

https://codereview.chromium.org/11363232/diff/7001/tools/perf/perf_tools/drom...
File tools/perf/perf_tools/dromaeo.py (right):

https://codereview.chromium.org/11363232/diff/7001/tools/perf/perf_tools/drom...
tools/perf/perf_tools/dromaeo.py:26: results.Add(Escape(k), 'runs/s', v)
Let's match the existing output:
results.Add('score', 'runs/s', v, chart_name=Escape(k), data_type='unimportant')

See:
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/dromaeo_domcor...

https://codereview.chromium.org/11363232/diff/7001/tools/perf/perf_tools/drom...
tools/perf/perf_tools/dromaeo.py:31: results.Add('dromaeo_' + suffix, '', score)
Again, matching the current format:
results.Add('score', 'runs/s', score, chart_name=suffix)

[bulach, 2012-11-21 20:44:06]

thanks tony! inline:

https://codereview.chromium.org/11363232/diff/7001/tools/perf/perf_tools/drom...
File tools/perf/perf_tools/dromaeo.py (right):

https://codereview.chromium.org/11363232/diff/7001/tools/perf/perf_tools/drom...
tools/perf/perf_tools/dromaeo.py:26: results.Add(Escape(k), 'runs/s', v)
On 2012/11/21 20:11:44, tonyg wrote:
> Let's match the existing output:
> results.Add('score', 'runs/s', v, chart_name=Escape(k),
data_type='unimportant')
> 
> See:
>
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/dromaeo_domcor...

Done.

https://codereview.chromium.org/11363232/diff/7001/tools/perf/perf_tools/drom...
tools/perf/perf_tools/dromaeo.py:31: results.Add('dromaeo_' + suffix, '', score)
On 2012/11/21 20:11:44, tonyg wrote:
> Again, matching the current format:
> results.Add('score', 'runs/s', score, chart_name=suffix)

right, I'm not entirely sure what the "unimportant" translates to, and I noticed
that this result is also available in the dict above... so I changed it
slightly, here's the output, let me know if this is what is supposed to be :)

*RESULT dom: score= 1456.0394416523084 runs/s
RESULT dom_attr: score= 605.6785833378896 runs/s
RESULT dom_attr_element_expando: score= 775.4901098901098 runs/s
RESULT dom_attr_element_expando___value: score= 227.64030760491997 runs/s
RESULT dom_attr_element_property: score= 1083 runs/s
RESULT dom_attr_element_property___value: score= 578.8833166833167 runs/s
RESULT dom_attr_getAttribute: score= 1348.2 runs/s
RESULT dom_attr_setAttribute: score= 330.86746506986026 runs/s
RESULT dom_modify: score= 280.75188006934235 runs/s
RESULT dom_modify_appendChild: score= 1029.2 runs/s
RESULT dom_modify_cloneNode: score= 121.29867193706359 runs/s
RESULT dom_modify_createElement: score= 348.0851942399189 runs/s
RESULT dom_modify_createTextNode: score= 220.56612419765543 runs/s
RESULT dom_modify_innerHTML: score= 54.65591248735393 runs/s
RESULT dom_modify_insertBefore: score= 934.8 runs/s
RESULT dom_query: score= 16494.721942452114 runs/s
RESULT dom_query_getElementById: score= 741.3564435564435 runs/s
RESULT dom_query_getElementById__not_in_documen: score= 2271.4 runs/s
RESULT dom_query_getElementsByName: score= 682.9906093906094 runs/s
RESULT dom_query_getElementsByName__not_in_docu: score= 1616.2 runs/s
RESULT dom_query_getElementsByTagName___: score= 130316 runs/s
RESULT dom_query_getElementsByTagName__not_in_d: score= 184143.2 runs/s
RESULT dom_query_getElementsByTagName_a_: score= 122343.6 runs/s
RESULT dom_query_getElementsByTagName_div_: score= 129004.2 runs/s
RESULT dom_query_getElementsByTagName_p_: score= 128391.4 runs/s
RESULT dom_traverse: score= 380.7162888502488 runs/s
RESULT dom_traverse_childNodes: score= 332.600865402063 runs/s
RESULT dom_traverse_firstChild: score= 318.7448380134323 runs/s
RESULT dom_traverse_lastChild: score= 299.33986013986015 runs/s
RESULT dom_traverse_nextSibling: score= 494.3026973026973 runs/s
RESULT dom_traverse_previousSibling: score= 509.8979020979021 runs/s

[tonyg, 2012-11-21 21:50:30]

lgtm

'unimportant' suppresses the * from before RESULT. Unimportant results don't
show up in the step's bubble on the waterfall. This keeps the UI more sane.

[bulach, 2012-11-22 10:02:28]

subtle difference :) thanks! CQing..

[commit-bot: I haz the power, 2012-11-22 10:02:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/11363232/10001

[commit-bot: I haz the power, 2012-11-22 11:43:53]

Change committed as 169254