Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 11363194: Enable 307 net unit tests on Android. (Closed)

Created:
8 years, 1 month ago by Philippe
Modified:
8 years, 1 month ago
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, felipeg, digit1, pasko-google - do not use
Visibility:
Public.

Description

Enable 307 net unit tests on Android. This is possible since r167167 landed. BUG=146979 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167653

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -114 lines) Patch
M build/android/gtest_filter/net_unittests_disabled View 1 chunk +41 lines, -113 lines 0 comments Download
M net/tools/testserver/testserver.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Philippe
8 years, 1 month ago (2012-11-13 14:04:46 UTC) #1
bulach
lgtm, great stuff, thanks!! as a follow up, would it be possible to file bugs ...
8 years, 1 month ago (2012-11-13 14:17:12 UTC) #2
Philippe
On 2012/11/13 14:17:12, bulach wrote: > lgtm, great stuff, thanks!! > > as a follow ...
8 years, 1 month ago (2012-11-13 14:32:34 UTC) #3
felipeg
lgtm
8 years, 1 month ago (2012-11-13 17:46:15 UTC) #4
Paweł Hajdan Jr.
LGTM, enabling tests = good. :)
8 years, 1 month ago (2012-11-13 18:14:19 UTC) #5
ppi
Absolutely. I have just created a meta-bug: http://code.google.com/p/chromium/issues/detail?id=160756 . I will be creating child-bugs for ...
8 years, 1 month ago (2012-11-13 18:31:44 UTC) #6
Philippe
On 2012/11/13 18:31:44, Przemek (ppi) wrote: > Absolutely. I have just created a meta-bug: > ...
8 years, 1 month ago (2012-11-14 09:53:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/11363194/8004
8 years, 1 month ago (2012-11-14 09:53:56 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-11-14 11:38:57 UTC) #9
Change committed as 167653

Powered by Google App Engine
This is Rietveld 408576698