Add CannedSyncableFileSystem::TouchFile for testing

Add CannedSyncableFileSystem::TouchFile for testing

BUG=none
TEST=tests using the method are to be added


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166884

[nhiroki, 2012-11-09 07:50:03]

lgtm

http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned...
File webkit/fileapi/syncable/canned_syncable_file_system.cc (right):

http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned...
webkit/fileapi/syncable/canned_syncable_file_system.cc:454: const base::Time&
access_time, const base::Time& modified_time,
nit: please add line break after "access_time,".

http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned...
File webkit/fileapi/syncable/canned_syncable_file_system.h (right):

http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned...
webkit/fileapi/syncable/canned_syncable_file_system.h:105: const base::Time&
modified_time);
naming-nit: I'd prefer "last_access_time" and "last_modified_time" like
FileSystemOperation.

http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned...
webkit/fileapi/syncable/canned_syncable_file_system.h:153: const base::Time&
modified_time,
ditto

[kinuko, 2012-11-09 07:55:33]

http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned...
File webkit/fileapi/syncable/canned_syncable_file_system.cc (right):

http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned...
webkit/fileapi/syncable/canned_syncable_file_system.cc:454: const base::Time&
access_time, const base::Time& modified_time,
On 2012/11/09 07:50:03, nhiroki wrote:
> nit: please add line break after "access_time,".

Done...

(by the way just to clarify, I don't think it's required in implementation)

http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned...
File webkit/fileapi/syncable/canned_syncable_file_system.h (right):

http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned...
webkit/fileapi/syncable/canned_syncable_file_system.h:105: const base::Time&
modified_time);
On 2012/11/09 07:50:03, nhiroki wrote:
> naming-nit: I'd prefer "last_access_time" and "last_modified_time" like
> FileSystemOperation.

Done.

http://codereview.chromium.org/11363161/diff/1/webkit/fileapi/syncable/canned...
webkit/fileapi/syncable/canned_syncable_file_system.h:153: const base::Time&
modified_time,
On 2012/11/09 07:50:03, nhiroki wrote:
> ditto

Done.

[commit-bot: I haz the power, 2012-11-09 08:10:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/11363161/12002

[commit-bot: I haz the power, 2012-11-09 10:09:29]

Change committed as 166884