Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2295)

Unified Diff: chrome/chrome_android.gypi

Issue 11363131: Specify jar name for apks in java_apk.gypi (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/java_apk.gypi ('k') | content/content_shell.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_android.gypi
diff --git a/chrome/chrome_android.gypi b/chrome/chrome_android.gypi
index a08f23c69c69970d400354c43e51a20df65b7f80..9748bda8902c312f83887ca8309543984308b253 100644
--- a/chrome/chrome_android.gypi
+++ b/chrome/chrome_android.gypi
@@ -76,23 +76,18 @@
{
# chromium_testshell creates a .jar as a side effect. Any java targets
# that need that .jar in their classpath should depend on this target,
- # chromium_testshell_java.
+ # chromium_testshell_java. Dependents of chromium_testshell receive its
+ # jar path in the variable 'apk_output_jar_path'.
'target_name': 'chromium_testshell_java',
'type': 'none',
'dependencies': [
- '../media/media.gyp:media_java',
- 'chrome.gyp:chrome_java',
'chromium_testshell',
],
- 'variables': {
- 'output_jar': '<(PRODUCT_DIR)/lib.java/chromium_apk_chromium_testshell.jar'
- },
- 'outputs': ['<(output_jar)'],
# This all_dependent_settings is used for java targets only. This will add
# the chromium_testshell jar to the classpath of dependent java targets.
'all_dependent_settings': {
'variables': {
- 'input_jars_paths': ['<(output_jar)'],
+ 'input_jars_paths': ['>(apk_output_jar_path)'],
},
},
# Add an action with the appropriate output. This allows the generated
@@ -101,7 +96,7 @@
{
'action_name': 'fake_generate_jar',
'inputs': [],
- 'outputs': ['<(output_jar)'],
+ 'outputs': ['>(apk_output_jar_path)'],
'action': [],
},
],
« no previous file with comments | « build/java_apk.gypi ('k') | content/content_shell.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698