Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 11363131: Specify jar name for apks in java_apk.gypi (Closed)

Created:
8 years, 1 month ago by cjhopman
Modified:
8 years, 1 month ago
Reviewers:
Yaron, Isaac (away), brettw
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, darin-cc_chromium.org, peter+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Specify jar name for apks in java_apk.gypi Previously, we had to keep this name in sync in multiple places, the "fake" xxx_java target and in sdk-targets.xml. Instead, it should be set only in java_apk.gypi and then passed along to each of the places that we were specifying it before. Also, delete unused 'output' block and unneeded xxx_java dependencies. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168148

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M build/android/ant/sdk-targets.xml View 1 chunk +1 line, -1 line 0 comments Download
M build/java_apk.gypi View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/chrome_android.gypi View 1 2 chunks +4 lines, -9 lines 0 comments Download
M content/content_shell.gypi View 1 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
cjhopman
8 years, 1 month ago (2012-11-07 21:00:53 UTC) #1
Yaron
lgtm http://codereview.chromium.org/11363131/diff/1/content/content_shell.gypi File content/content_shell.gypi (right): http://codereview.chromium.org/11363131/diff/1/content/content_shell.gypi#newcode589 content/content_shell.gypi:589: # its jar path in the variable 'apk_output_jar_path'. ...
8 years, 1 month ago (2012-11-08 02:22:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11363131/4001
8 years, 1 month ago (2012-11-12 17:26:30 UTC) #3
commit-bot: I haz the power
Presubmit check for 11363131-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-12 17:26:34 UTC) #4
cjhopman
brettw@ for owners http://codereview.chromium.org/11363131/diff/1/content/content_shell.gypi File content/content_shell.gypi (right): http://codereview.chromium.org/11363131/diff/1/content/content_shell.gypi#newcode589 content/content_shell.gypi:589: # its jar path in the ...
8 years, 1 month ago (2012-11-14 23:32:53 UTC) #5
Isaac (away)
Now that OWNERS works on a per-file basis, seems reasonable to add a couple android ...
8 years, 1 month ago (2012-11-15 06:20:47 UTC) #6
brettw
LGTM, I'd ask Ben about the owners change.
8 years, 1 month ago (2012-11-15 20:34:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11363131/4001
8 years, 1 month ago (2012-11-15 20:51:43 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-15 21:37:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11363131/4001
8 years, 1 month ago (2012-11-15 21:50:19 UTC) #10
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 1 month ago (2012-11-16 02:37:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11363131/4001
8 years, 1 month ago (2012-11-16 02:38:37 UTC) #12
commit-bot: I haz the power
8 years, 1 month ago (2012-11-16 07:31:50 UTC) #13
Change committed as 168148

Powered by Google App Engine
This is Rietveld 408576698