Check for login screen availibility before showing spinner.

Check for login screen availibility before showing spinner.
In retail mode, if for any reason, the login UI underneath the screensaver goes away (possibly due to a login happening while the screensaver was still starting up), we currently crash. Instead in that case, we want to just not try to show a spinner and close the screensaver and log
 the user in instead.

R=nkostylev@chromium.org
BUG=159433
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166784

[Nikita (slow), 2012-11-07 10:51:37]

http://codereview.chromium.org/11363109/diff/3001/chrome/browser/chromeos/kio...
File chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc (right):

http://codereview.chromium.org/11363109/diff/3001/chrome/browser/chromeos/kio...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:180: if
(chromeos::UserManager::Get()->IsSessionStarted())
Difference between these two is that IsSessionStarted() will return true when we
are past choose avatar screen.
In retail mode case that should not happen, right?

Leave IsUserLoggedIn() ?

http://codereview.chromium.org/11363109/diff/3001/chrome/browser/chromeos/kio...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:202: if
(WebUILoginDisplayHost::default_host()) {
If default_host is gone now I believe login already happened so calling
LoginAsDemoUser() seems to be redundant?

[rkc, 2012-11-07 20:25:01]

http://codereview.chromium.org/11363109/diff/3001/chrome/browser/chromeos/kio...
File chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc (right):

http://codereview.chromium.org/11363109/diff/3001/chrome/browser/chromeos/kio...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:180: if
(chromeos::UserManager::Get()->IsSessionStarted())
On 2012/11/07 10:51:37, Nikita Kostylev wrote:
> Difference between these two is that IsSessionStarted() will return true when
we
> are past choose avatar screen.
> In retail mode case that should not happen, right?
> 
> Leave IsUserLoggedIn() ?

IsSessionStarted seemed more appropriate (since it means that the user session
has actually started, versus there is a logged in user) - but yes, both should
do the same thing for KioskMode.

Done.

http://codereview.chromium.org/11363109/diff/3001/chrome/browser/chromeos/kio...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:202: if
(WebUILoginDisplayHost::default_host()) {
On 2012/11/07 10:51:37, Nikita Kostylev wrote:
> If default_host is gone now I believe login already happened so calling
> LoginAsDemoUser() seems to be redundant?

If you're certain that is the only case that the default_host would be gone for,
then not doing the LoginAsDemoUser makes sense.

Done.

[Nikita (slow), 2012-11-08 17:58:40]

lgtm

http://codereview.chromium.org/11363109/diff/7001/chrome/browser/chromeos/kio...
File chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc (right):

http://codereview.chromium.org/11363109/diff/7001/chrome/browser/chromeos/kio...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:218: if (controller
&& !chromeos::UserManager::Get()->IsSessionStarted())
This should still use IsUserLoggedIn() as there's a delay between this two when
profile is prepared.

[rkc, 2012-11-08 20:06:57]

http://codereview.chromium.org/11363109/diff/7001/chrome/browser/chromeos/kio...
File chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc (right):

http://codereview.chromium.org/11363109/diff/7001/chrome/browser/chromeos/kio...
chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc:218: if (controller
&& !chromeos::UserManager::Get()->IsSessionStarted())
On 2012/11/08 17:58:40, Nikita Kostylev wrote:
> This should still use IsUserLoggedIn() as there's a delay between this two
when
> profile is prepared.

Done.

[commit-bot: I haz the power, 2012-11-08 20:30:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/11363109/3

[commit-bot: I haz the power, 2012-11-08 22:33:42]

Change committed as 166784