Android: Report step failure when tests time out.

Android: Report step failure when tests time out.

Currently when tests time out, we retry them but still mark the step as
a warning, which does not cause a step failure.

We should report a failure when tests time out. Also adding more stats
on how many tests we were supposed to run and how many we failed to run.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166132

[nilesh, 2012-11-05 22:35:17]

http://codereview.chromium.org/11363088/diff/1/build/android/gtest_filter/con...
File build/android/gtest_filter/content_unittests_disabled (right):

http://codereview.chromium.org/11363088/diff/1/build/android/gtest_filter/con...
build/android/gtest_filter/content_unittests_disabled:21: #
WebContentsVideoCaptureDeviceTest.*
Will revert this change. Added this to test the timeout behavior on trybots.

[Yaron, 2012-11-05 22:52:13]

lgtm

http://codereview.chromium.org/11363088/diff/1/build/android/pylib/test_resul...
File build/android/pylib/test_result.py (right):

http://codereview.chromium.org/11363088/diff/1/build/android/pylib/test_resul...
build/android/pylib/test_result.py:181: num_tests_ran = len(self.ok) +
len(self.failed) + \
nit: prefer wrapping expression in parens instead of using "\"

http://codereview.chromium.org/11363088/diff/1/build/android/pylib/test_resul...
build/android/pylib/test_result.py:192: if (num_tests_ran != len(tests_to_run)):
nit: remove parens

[nilesh, 2012-11-05 23:08:00]

http://codereview.chromium.org/11363088/diff/1/build/android/pylib/test_resul...
File build/android/pylib/test_result.py (right):

http://codereview.chromium.org/11363088/diff/1/build/android/pylib/test_resul...
build/android/pylib/test_result.py:181: num_tests_ran = len(self.ok) +
len(self.failed) + \
On 2012/11/05 22:52:13, Yaron wrote:
> nit: prefer wrapping expression in parens instead of using "\"

Done.

http://codereview.chromium.org/11363088/diff/1/build/android/pylib/test_resul...
build/android/pylib/test_result.py:192: if (num_tests_ran != len(tests_to_run)):
On 2012/11/05 22:52:13, Yaron wrote:
> nit: remove parens

Done.

[Isaac (away), 2012-11-06 00:10:43]

lgtm with nit about string building (offline comment)

[nilesh, 2012-11-06 00:35:39]

Using a list to build the summary string.
Thanks for the reviews.

[commit-bot: I haz the power, 2012-11-06 00:36:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/11363088/3003

[commit-bot: I haz the power, 2012-11-06 03:45:55]

Change committed as 166132

[frankf, 2012-11-07 17:37:25]

On 2012/11/06 03:45:55, I haz the power (commit-bot) wrote:
> Change committed as 166132

This broke run_monkey_test:

http://clankbotmaster.corp.google.com:8116/builders/release-tests-dev/builds/...